Use test map for checking --version-script, instead of full map #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, if anybody knows a way to have |
|
@DimitryAndric Please rebase on master to make the Linux test pass (fixed by #586). This test looks much simpler indeed. @whot @bluetech I wonder if we need to test the real file here anyway, to detect extra features?
CC to our Meson wizard @whot. |
Various problems can occur when using the full `xkbcommon.map` file when checking whether the `--version-script` linker option works in `meson.build`. For instance, newer linkers typically complain about non-existing symbols, so in commit ebe4157 `--undefined-version` was added to work around that. But then in commit 1d8a25d another workaround needed to be added for older linkers. It is better to use a minimalistic linker script for testing instead. The other workarounds can then be removed.
DimitryAndric
force-pushed
the
fix-version-script-check-1
branch
from
2171f76 to
c9e822b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various problems can occur when using the full
xkbcommon.mapfile when checking whether the--version-scriptlinker option works inmeson.build. See https://lists.freebsd.org/archives/freebsd-current/2025-January/006888.html for an example.For instance, newer linkers typically complain about non-existing symbols, so in commit ebe4157
--undefined-versionwas added to work around that. But then in commit 1d8a25d another workaround needed to be added for older linkers.It is better to use a minimalistic linker script for testing instead. The other workarounds can then be removed.