Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always retain later Compose sequence in case of conflict #570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Dec 21, 2024

This ensures that it is always possible to override previous definitions, for example when includeing the system Compose file.

Fixes #395, as a stopgap while waiting for #398.

This ensures that it is always possible to override previous definitions,
for example when `include`ing the system Compose file.

Signed-off-by: Jules Bertholet <julesbertholet@quoi.xyz>
@wismill
Copy link
Member

wismill commented Jan 24, 2025

It seems the proper behavior. It bothered me several times. But the manual is ambiguous:

For example, you can include in your compose file the default Compose file by using:
include "%L"
and then rewrite only the few rules that you need to change. New compose rules can be added, and previous ones replaced.

It does not say exactly what to do in case of overlap if the sequence length are different.

@bluetech @whot I cannot find a reference to the motivation of keeping always the largest sequence.

@wismill wismill added compose Indicates a need for improvements or additions to Compose handling needs info labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Indicates a need for improvements or additions to Compose handling needs info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xkbcommon supports no way for a prefix pattern to override a longer pattern matching the prefix
2 participants