Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POSIX shell in scripts #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use POSIX shell in scripts #187

wants to merge 1 commit into from

Conversation

czarkoff
Copy link

@czarkoff czarkoff commented Jan 9, 2016

Some systems don't have bash at /bin/bash, or may use other shells by default

Some systems don't have bash at /bin/bash, or may use other shells by default
@tdaede
Copy link
Contributor

tdaede commented Jan 12, 2016

Did you verify that the scripts work on other sh implementations?

Indeed, other systems might use other default shells, which is why bash is explicitly specified.

I'm not sure this patch will fix more than it breaks - we don't currently have a way to prevent bash-isms from slipping into scripts.

@czarkoff
Copy link
Author

I verified some with ksh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants