Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor-修改公共异常名称 #36

Closed
wants to merge 0 commits into from

Conversation

changzheng0101
Copy link
Contributor

MuYunException相比于MyException,感觉是一个更好的名称

@changzheng0101
Copy link
Contributor Author

添加commit: 修正了一处笔误

@aruis
Copy link
Collaborator

aruis commented Dec 26, 2024

尴尬,我已经在其他项目了在使用这个 MyException 了,如果这时候改平台的,估计别的项目要报错了。 恐怕我不能合并这个PR。

@changzheng0101
Copy link
Contributor Author

理解,感觉可以将异常重命名加入计划中,在某个版本进行大更改,因为作为平台的定位的话,个人感觉MyException还是很不优雅的。

@gtn1024
Copy link
Contributor

gtn1024 commented Dec 26, 2024

定义一个新的 MuYunException,让 MyException 继承他然后标记 @Deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants