Media library image element remove new prop

relates to xibosignageltd/xibo-private#294
xibosignage · Oct 10, 2023 · 96fabc6 · 96fabc6
1 parent 9b5c144
commit 96fabc6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/modules/templates/global-elements.xml b/modules/templates/global-elements.xml
@@ -465,9 +465,6 @@ $(target).find('.date').each(function(_idx, dateEl){
         <canRotate>true</canRotate>
         <startWidth>250</startWidth>
         <startHeight>250</startHeight>
-        <properties>
-            <property id="mediaId" type="text"></property>
-        </properties>
     </template>
     <template>
         <id>line</id>

diff --git a/ui/src/editor-core/widget.js b/ui/src/editor-core/widget.js
@@ -661,15 +661,6 @@ Widget.prototype.saveElements = function(
     // Save only id and value for element properties if they are not empty
     if (element.properties != undefined) {
       element.properties = Object.values(element.properties).map((property) => {
-        // If property is mediaId and it's null, use element mediaId
-        if (
-          property.id === 'mediaId' &&
-          element.mediaId !== undefined &&
-          property.value === null
-        ) {
-          property.value = element.mediaId;
-        }
-
         return {
           id: property.id,
           value: property.value,

diff --git a/ui/src/layout-editor/viewer.js b/ui/src/layout-editor/viewer.js
@@ -1746,7 +1746,7 @@ Viewer.prototype.renderElementContent = function(
             convertedProperties[extendOverrideKey] = meta[metaKey];
           } else if (extendWithDataKey === 'mediaId') {
             convertedProperties[extendOverrideKey] =
-              '[[mediaId=' + convertedProperties[extendWithDataKey] + ']]';
+              '[[mediaId=' + element.mediaId + ']]';
           } else {
             convertedProperties[extendOverrideKey] =
               (elData) && elData[extendWithDataKey];