-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: #767 . #788
Merged
Merged
FIX: #767 . #788
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5114dc6
fixed issue https://github.com/xiaolin/react-image-gallery/issues/767
hunxjunedo 80744fe
removed semi-colons
hunxjunedo c44289f
add semi-colons
hunxjunedo 3d51b44
fixed all errors shown by eslint
hunxjunedo 6a3f3a6
applied changes according to review, fixed issue #767
hunxjunedo a1c61d1
fixed RTL slide issue. BTW why is grammar emphasized this much ?
hunxjunedo 78226da
Update src/components/ImageGallery.jsx
xiaolin 1dcbf4d
Update src/components/ImageGallery.jsx
xiaolin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar fix here:
// When isRTL is true, the logic is reversed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I would rather have the comment removed because the code you've provided is self-explanatory. But since you left a comment, it will alert a contributor to read it, so it should be clear and concise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright. A side note, it's my first time contributing to kindly excuse any inconvenience caused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No inconvenience at all, this is part of the code review process. Thank you for contributing!