Tutorials: XGI in X minutes #415
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 90.90% 91.84% +0.93%
==========================================
Files 47 60 +13
Lines 3916 4255 +339
==========================================
+ Hits 3560 3908 +348
+ Misses 356 347 -9 ☔ View full report in Codecov by Sentry. |
|
Thank you @maximelucas I will address your comments in the next days while working on the 15 min tuto |
|
As Leo mentioned somewhere, we should check that the Github Action testing the notebook will test the new ones (it might test only names "Tutorial_*"). Quickly look at it though, it though looks fine? |
|
Ok, the three tutorials are ready, I have already addressed the comments by @maximelucas. As I had mentioned on Zulip maybe we can merge this before releasing the new version and then proceed with the rest of the tutorial restructuring (that's why I have renamed the PR and unlinked #414) later. |
| @@ -0,0 +1,679 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,679 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,679 @@ | |||
| { | |||
There was a problem hiding this comment.
After this I would just say something like "For other hypergraph matrices such as Laplacians, see the linalg documentation" with a link.
Reply via ReviewNB
| @@ -0,0 +1,679 @@ | |||
| { | |||
There was a problem hiding this comment.
Before wrapping up (or earlier in the tuto), what do you think of just advertising the stats with 2 short examples, and the link to docs/tuto?
Like
- H.nodes.filterby("degree", 2)
- df = H.nodes.multi(["degree", "clustering_coefficient"]).aspandas()
Reply via ReviewNB
|
thank you @maximelucas for the comments, everything should be good to go now from my side |
|
the only thing is that I am not entirely sure that the hyperlinks to the XGI in [...] minutes are all working, in case I will do a micro PR fixing that :) |
|
Looks good, thanks Thomas!! |
I plan on working on this PR related to #414 over the next two weeks.
(quick note: the texts rely heavily on chatGPT's joy of life, we can then decide to tone it down a bit 😄)