fix: handling export declarations #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benji Visser <[email protected]>
noqcks
commented
May 9, 2024
| // handling the case of 'export * from "x"' where the name is __export | ||
| // for all exports of this type, but we need to make sure ids are unique | ||
| // in the graph | ||
| if (n.getKind() === SyntaxKind.ExportDeclaration && name === "__export") { |
There was a problem hiding this comment.
might eventually split this out into its own branching logic per node type if it gets more complicated, starting to smell
even this line is smelly
const nodeName = "getName" in n ? n.getName() : n.getSymbol()?.getName();
There was a problem hiding this comment.
I think we should fix this when we revamp the ID approach (map nodes by similarity)
zlalvani
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling export declarations as top level items. We weren't handling this before, so if an error occurred on one of these lines, we would be able to fix the error.
please take a look at the test snapshot
ts ast example