refactor: search and replace improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihanwan
force-pushed
the
search-and-replace-improvements
branch
from
4772c77 to
325eb86
Compare
noqcks
approved these changes
Apr 26, 2024
shihanwan
changed the title
shihanwan
changed the title
zlalvani
reviewed
May 2, 2024
| const countIndents = (line: string) => { | ||
| let count = 0; | ||
| // eslint-disable-next-line @typescript-eslint/prefer-for-of | ||
| for (let i = 0; i < line.length; i++) { |
There was a problem hiding this comment.
you can use for (const char of line) here
shihanwan
force-pushed
the
search-and-replace-improvements
branch
from
52ad617 to
8883a19
Compare
zlalvani
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.