Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEOK-54 Expose SceneModelEntity's area and volume #1577

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichalDybizbanskiCreoox
Copy link
Collaborator

This PR introduces SceneModelEntity::area and ::volume getters.
The metrics are computed during load time, and don't rely on run-time geometry information, thus assuming SceneModelEntity geometries don't change.
IMPORTANT: The metrics have been implemented for VBOBatchingTrianglesLayer and VBOInstancingTrianglesLayer, but not for DTXTrianglesLayer.

Another PR has been merged to the master branch, which uses a different approach, but provides the same metrics, at
#1574
so this one becomes a Draft PR for the time being.

<meta name="viewport" content="width=device-width, initial-scale=1">
<title>xeokit Example</title>
<link href="../css/pageStyle.css" rel="stylesheet"/>
<script src="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/js/all.min.js"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant