Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialization for dataset #139

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

slevang
Copy link
Contributor

@slevang slevang commented Dec 17, 2023

Serialize/deserialize weren't working properly for the preprocessor transformers when passed a Dataset. This seems to fix the immediate issue in #135. I want to add new tests though and dig a bit deeper.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (0f95d04) 94.21% compared to head (ff9a1be) 94.39%.
Report is 52 commits behind head on main.

Files Patch % Lines
xeofs/utils/numba_utils.py 20.96% 49 Missing ⚠️
xeofs/data_container/data_container.py 88.88% 3 Missing ⚠️
xeofs/preprocessing/stacker.py 72.72% 3 Missing ⚠️
xeofs/models/_base_cross_model.py 96.07% 2 Missing ⚠️
xeofs/models/_base_model.py 96.07% 2 Missing ⚠️
xeofs/models/decomposer.py 86.66% 2 Missing ⚠️
xeofs/preprocessing/preprocessor.py 88.88% 2 Missing ⚠️
xeofs/utils/xarray_utils.py 88.88% 2 Missing ⚠️
xeofs/utils/io.py 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   94.21%   94.39%   +0.17%     
==========================================
  Files          71       73       +2     
  Lines        5823     6152     +329     
==========================================
+ Hits         5486     5807     +321     
- Misses        337      345       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slevang slevang changed the title fix: handle preprocessor serialization for dataset fix: serialization for dataset Dec 17, 2023
@slevang slevang marked this pull request as ready for review December 17, 2023 20:21
@nicrie
Copy link
Contributor

nicrie commented Dec 18, 2023

nice! thanks @slevang for this quick fix, I'll review later tonight!

@nicrie nicrie merged commit 93fce38 into xarray-contrib:main Dec 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants