[Rgen] Add support to parse the CoreImageFilter attribute. #22043

mandel-macaque · 2025-01-24T23:02:54Z

We needed to fix the way we compile the apidefiniton to include the mono.cecil dll. We added the dependency to the test project and used the path to that reference, which is easier that trying to deal with nuget pkgs in the tests.

github-actions · 2025-01-24T23:07:04Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

We needed to fix the way we compile the apidefiniton to include the mono.cecil dll. We added the dependency to the test project and used the path to that reference, which is easier that trying to deal with nuget pkgs in the tests.

…he transformer. (#22044) We need to be able to parse it to convert it to the new API. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>

This way we can later decide if we perform the UI thread check. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>

vs-mobiletools-engineering-service2 · 2025-01-25T15:31:47Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T15:31:50Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T15:53:06Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T16:04:02Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T16:11:41Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T16:12:03Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T16:12:27Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 1f12f19a1927a906b8444e02cf3112245f4ef03d [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T16:12:29Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T16:12:40Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-25T23:20:43Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 118 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fba23cf0a68b224c609dbf67be373200f887a4b2 [PR build]

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 25, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque and others added 4 commits January 25, 2025 08:11

[Rgen] Add the code needed to parse the core image property attr in t…

2279c2b

…he transformer. (#22044) We need to be able to parse it to convert it to the new API. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>

[Rgen] Keep track if a type is a dictionary container. (#22042)

7f94d92

[Rgen] Allow to mark bindings as thread safe. (#22045)

53589a3

This way we can later decide if we perform the UI thread check. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>

mandel-macaque force-pushed the dev/mandel/transformer-coreimage-filter branch from 978e7ff to 53589a3 Compare January 25, 2025 13:12

Merge branch 'main' into dev/mandel/transformer-coreimage-filter

1f12f19

mandel-macaque merged commit fba23cf into main Jan 25, 2025
6 of 9 checks passed

mandel-macaque deleted the dev/mandel/transformer-coreimage-filter branch January 25, 2025 13:13

[Rgen] Add support to parse the CoreImageFilter attribute. #22043

[Rgen] Add support to parse the CoreImageFilter attribute. #22043

Conversation

mandel-macaque commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 25, 2025

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Jan 25, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 25, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 25, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 25, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 25, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 25, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 25, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 25, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 25, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts