-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provisional Feature/netcore integration #436
Draft
andyward
wants to merge
417
commits into
develop
Choose a base branch
from
feature/netcore
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asure sub-types to be used
…l with IfcParameterValues but just warn
…ermitting use of derived measures.
String.Format() with > 3 args fails to compile. See: https://developercommunity.visualstudio.com/t/Error-with-String::Format-in-C-CLR-Cla/10788352 Impact: XbimOccShape.cxx fails to compile in WriteTriangulation() at L136
Fixes VS testt Explorer/xunit runner failing to load tests in all platforms/configs/targets. Now permits running unit tests in Release config etc.
Specifically this test triggers "Invalid Program: attempted to call a UnmanagedCallersOnly method from managed code" but only in release mode.
Root cause was un-initialised local bool variable. Enabled code analysis to pick up in future (and fixed other similar cases)
…wallthickness values in IfcCShapeProfileDef are same
* Fix for memory access violation when filling loop #512 While an edge case, the root cause is that ages ago we incorrectly added OCC 'No_Exception' Preprocessor directive in Release builds, essentially making all managed exception handling useless outside of Debug builds Slightly tidied OCC targets to remove duplicate elements.
Cherry pick of develop (5.1) into netcore
… get correct exception handling in Release mode Related to #512. OCC now built with public repo at https://github.com/xBimTeam/xbimGeometryOcct using repeatable script. Deployment of OCC native dlls now left to Xbim.Geometry.Occt package, reducing size of Xbim.GE.Interop package
…CCT itself. Major.Minor.Patch follow OCCs version Build no. etc used for our use Only change is folder structure internally in OCCT nuget + use of standard occt targets file to identify TK libs
Renamed native netcore project for clarity - non-breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.