Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisional Feature/netcore integration #436

Draft
wants to merge 417 commits into
base: develop
Choose a base branch
from
Draft

Conversation

andyward
Copy link
Member

No description provided.

Ibrahim Saad and others added 30 commits December 13, 2024 14:09
String.Format() with > 3 args fails to compile. See:

https://developercommunity.visualstudio.com/t/Error-with-String::Format-in-C-CLR-Cla/10788352

Impact: XbimOccShape.cxx fails to compile in WriteTriangulation() at L136
Fixes VS testt Explorer/xunit runner failing to load tests in all platforms/configs/targets.

Now permits running unit tests in Release config etc.
Specifically this test triggers "Invalid Program: attempted to call a UnmanagedCallersOnly method from managed code"
but only in release mode.
Root cause was un-initialised local bool variable.
Enabled code analysis to pick up in future (and fixed other similar cases)
…wallthickness values in IfcCShapeProfileDef are same
* Fix for memory access violation when filling loop #512

While an edge case, the root cause is that ages ago we incorrectly added OCC 'No_Exception' Preprocessor directive in Release builds, essentially making all managed exception handling useless outside of Debug builds

Slightly tidied OCC targets to remove duplicate elements.
…518)

- resulting in infinite sized Region. Follow up issue for #512
Cherry pick of develop (5.1) into netcore
… get correct exception handling in Release mode

Related to #512. OCC now built with public repo at https://github.com/xBimTeam/xbimGeometryOcct using repeatable script.

Deployment of OCC native dlls now left to Xbim.Geometry.Occt package, reducing size of Xbim.GE.Interop package
…CCT itself. Major.Minor.Patch follow OCCs version

Build no. etc used for our use

Only change is folder structure internally in OCCT nuget + use of standard occt targets file to identify TK libs
Renamed native netcore project for clarity - non-breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants