Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflict exception should extend XGraphQL\SchemaGateway\Exception\RuntimeException instead #20

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

vuongxuongminh
Copy link
Member

…on\RuntimeException` instead

@vuongxuongminh vuongxuongminh changed the title fix: conflict exception should extend `XGraphQL\SchemaGateway\Excepti… fix: conflict exception should extend XGraphQL\SchemaGateway\Exception\RuntimeException instead Mar 24, 2024
@vuongxuongminh vuongxuongminh merged commit e67df1e into main Mar 24, 2024
2 checks passed
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (10d84a2) to head (4f7a1b6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #20   +/-   ##
=========================================
  Coverage     98.90%   98.90%           
  Complexity      157      157           
=========================================
  Files            10       10           
  Lines           642      642           
=========================================
  Hits            635      635           
  Misses            7        7           
Flag Coverage Δ
phpunit 98.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vuongxuongminh vuongxuongminh deleted the prefer-to-extends-internal-runtime-exception branch March 24, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant