-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hsp alignment download reformat #603
base: master
Are you sure you want to change the base?
Conversation
|
Hey @iQuxLE - do these code climate need to be fixed? or are they minor? And/or are they related to the conflicts that need to be resolved. Are you able to resolve those? |
I suppose the issues are more minor. It is just a duplication in two locations and minimizing that won't make it more intuitive and easier to understand. |
Are you able to tell Codeclimate to ignore those minor issues (through local in-line ignore/reconfig comments?) |
changing threshold to avoid similar code in sidebar.js
updated codeclimate.yml with a filter to prevent duplication call for sidebar.js
I added filters for the specific functions inside alignment_exporter.js and sidebar.js |
Given the number of 'Update xyz' kind of commits, it may be desirable to squash-and-merge this PR. That would be |
I think I have not used the most recent commit that's why there is a conflict cause I don't see the details for this. Let me check the next days. |
Yes I think we need a Github action that automatically rebuilds minimised js and css whenever the repo moves
|
bump |
@augeas - could you please pull out the essentials from here? |
FASTA headers of the downloaded HSP alignments now show the hit number and hsp number (in letters) that the user is currently looking at.