chore: add controlplane tests

wundergraph · Oct 24, 2024 · 1896d33 · 1896d33
1 parent c2695e2
commit 1896d33
Show file tree

Hide file tree

Showing 7 changed files with 810 additions and 83 deletions.
diff --git a/composition-go/index.global.js b/composition-go/index.global.js
diff --git a/composition/src/federation/federation-factory.ts b/composition/src/federation/federation-factory.ts
@@ -2615,19 +2615,6 @@ export class FederationFactory {
                 ]);
                 this.inaccessiblePaths.add(`${parentTypeName}.${fieldName}`);
                 accessibleFields -= 1;
-                continue;
-              }
-              for (const [argumentName, inputValueData] of fieldData.argumentDataByArgumentName) {
-                if (isNodeDataInaccessible(inputValueData)) {
-                  continue;
-                }
-                const argumentTagNames = childTagData.tagNamesByArgumentName.get(argumentName);
-                if (!argumentTagNames || !doSetsIntersect(argumentTagNames, argumentTagNames)) {
-                  getValueOrDefault(inputValueData.persistedDirectivesData.directives, INACCESSIBLE, () => [
-                    generateSimpleDirective(INACCESSIBLE),
-                  ]);
-                  this.inaccessiblePaths.add(inputValueData.renamedPath);
-                }
               }
             }
             if (accessibleFields < 1) {

diff --git a/composition/tests/contracts.test.ts b/composition/tests/contracts.test.ts
@@ -802,6 +802,26 @@ describe('Contract tests', () => {
       );
     });
 
+    test('that if a Field is included, its Arguments are included by default', () => {
+      const { errors, federationResult } = federateSubgraphsContract([subgraphInclude, subgraphAL], includedTagsOne);
+      expect(errors).toBeUndefined();
+      expect(schemaToSortedNormalizedString(federationResult!.federatedGraphClientSchema)).toBe(
+        normalizeString(
+          schemaQueryDefinition +
+            `
+            type Object {
+              name: String!
+            }
+
+            type Query {
+              field(input: ID!): Object!
+              include: Int!
+            }
+          `,
+        ),
+      );
+    });
+
     test('that a Scalar is included by tag', () => {
       const { errors, federationResult } = federateSubgraphsContract(
         [subgraphInclude, subgraphQ, subgraphR],
@@ -2880,3 +2900,17 @@ const subgraphAK: Subgraph = {
     }
   `),
 };
+
+const subgraphAL: Subgraph = {
+  name: 'subgraph-al',
+  url: '',
+  definitions: parse(`
+    type Object @tag(name: "one") {
+      name: String!
+    }
+    
+    type Query {
+      field(input: ID!): Object! @tag(name: "one")
+    }
+  `),
+};