Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test to get user defined local authenticators. #22077

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add integration test to get user defined local authenticators. #22077

wants to merge 8 commits into from
+39 −5

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla mentioned this pull request Dec 19, 2024
Open
ashanthamara
ashanthamara previously approved these changes Jan 2, 2025
View reviewed changes
ashanthamara
ashanthamara previously approved these changes Jan 3, 2025
View reviewed changes
@wso2 wso2 deleted a comment from jenkins-is-staging Jan 17, 2025
@wso2 wso2 deleted a comment from jenkins-is-staging Jan 17, 2025
@wso2 wso2 deleted a comment from jenkins-is-staging Jan 17, 2025
@wso2 wso2 deleted a comment from jenkins-is-staging Jan 17, 2025
@wso2 wso2 deleted a comment from jenkins-is-staging Jan 17, 2025
@wso2 wso2 deleted a comment from jenkins-is-staging Jan 17, 2025
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12936614438

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12936614438
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12942244628

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12942244628
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-integration-tests-for-configs-auth branch from 7be795c to d2b0928 Compare January 24, 2025 04:50
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12943478672

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12943478672
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-integration-tests-for-configs-auth branch from d2b0928 to a9a9072 Compare January 24, 2025 06:43
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12944673581

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12944673581
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12944673581

ashanthamara
ashanthamara reviewed Jan 24, 2025
View reviewed changes
...y/integration/test/rest/api/server/authenticator/management/v1/AuthenticatorSuccessTest.java
.body("displayName", equalTo(AUTHENTICATOR_DISPLAY_NAME))
.body("type", equalTo("LOCAL"))
.body("definedBy", equalTo("USER"))
.body("isEnabled", equalTo(true));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check the imageUrl as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashanthamara ashanthamara ashanthamara left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thisara-Welmilla @jenkins-is-staging @ashanthamara