Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getKeystoreInstance from KeystoreUtils #21623

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Use getKeystoreInstance from KeystoreUtils #21623

merged 1 commit into from
Nov 6, 2024

Conversation

hwupathum
Copy link
Contributor

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11698472349

Copilot
Copilot AI reviewed Nov 6, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • modules/integration/tests-common/admin-clients/src/main/java/org/wso2/identity/integration/common/clients/KeyStoreAdminClient.java: Evaluated as low risk
  • modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/oidc/OIDCAuthzCodeIdTokenValidationTestCase.java: Evaluated as low risk
@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11698472349
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11698472349

@hwupathum hwupathum merged commit cbd2c6d into wso2:master Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@madurangasiriwardena madurangasiriwardena madurangasiriwardena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwupathum @jenkins-is-staging @madurangasiriwardena