Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp device code automation test #21495

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Revamp device code automation test #21495

merged 2 commits into from
Nov 1, 2024

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Oct 25, 2024 •
edited
Loading

Public Issue : #21313

Current automation test suite only cover happy path with super tenant and some error scenarios. But with this revamp we are introducing

  • Both Super tenant and sub tenant modes.
  • Automated Scenarios
    • Device Authz request
      • Valid device authz request
      • Without Client Id
      • With Invalid Client Id
    • Authentication
      • Login with Valid User code
      • Login with Invalid User code
    • Valid Device Token Call
      • Valid Token call
      • Token call with interval -> slow_down
      • Token call before authorization -> authrotization pending
      • Repeted Token call after token retrivel -> expired_token
    • Invalid Device Token Call
      • TokenRequestWithoutGrantType
      • TokenRequestWithInvalidGrantType
      • TokenRequestWithoutClientId
      • TokenRequestWithInvalidClientId
      • TokenRequestWithoutDeviceCode
      • TokenRequestWithInvalidDeviceCode

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11518607171

@Thumimku Thumimku mentioned this pull request Oct 25, 2024
Open
10 tasks
@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11518607171
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11521387905

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11521387905
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11527818665

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11527818665
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11527818665

@Thumimku
Copy link
Contributor Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/11521387905 Status: failure

These failures occurs because this PR adopts the changes of source pr but the integration suite triggered before the dependency got updated.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11590628502

JeethJJ
JeethJJ reviewed Oct 30, 2024
View reviewed changes
...ackend/src/test/java/org/wso2/identity/integration/test/oauth2/OAuth2DeviceFlowTestCase.java
private void setServerEndpoints() throws Exception {

String deviceAuthEndpointBaseUrl = context.getContextUrls().getBackEndUrl()
.replace("services/", "oauth2/device_authorize");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we don't use variables for the URL strings?

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11590628502
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11590628502

@Thumimku Thumimku merged commit cc9232e into wso2:master Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeethJJ JeethJJ JeethJJ left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@DMHP DMHP DMHP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thumimku @jenkins-is-staging @DMHP @JeethJJ