-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Idle Account Suspension API to return disabled and non-disabled users #768
Improve Idle Account Suspension API to return disabled and non-disabled users #768
Conversation
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12822674920
62027fc
to
0e0565f
Compare
# Conflicts: # components/org.wso2.carbon.identity.api.idle.account.identification/org.wso2.carbon.identity.api.idle.account.identification.v1/src/main/java/org/wso2/carbon/identity/api/idle/account/identification/v1/impl/InactiveUsersApiServiceImpl.java # pom.xml
4a381a2
to
24667a5
Compare
...so2/carbon/identity/api/idle/account/identification/v1/impl/InactiveUsersApiServiceImpl.java
Show resolved
Hide resolved
...rbon/identity/api/idle/account/identification/v1/core/InactiveUsersManagementApiService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/idle/account/identification/v1/core/InactiveUsersManagementApiService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/idle/account/identification/v1/core/InactiveUsersManagementApiService.java
Outdated
Show resolved
Hide resolved
...rbon/identity/api/idle/account/identification/v1/core/InactiveUsersManagementApiService.java
Outdated
Show resolved
Hide resolved
…o Idle-Account-Suspension-API
Purpose
This PR enhance the getInactiveUsers API to:
Implementation
Implementation introduces a new queryParameter, filter, to decide on whether to include disabled users or exclude disabled users.
When filter=isDisabled eq true it returns all the inactive and disabled users for a given time period whose account state is DISABLED.
When filter=isDisabled eq false it returns all the inactive and non-disabled users for a given time period.
Tested in H2, MySQL, PostgreSQL, MSSQL, Oracle databases.
Example
Sample Request
https://localhost:9443/api/idle-account-identification/v1/inactive-users?inactiveAfter=2024-12-21&excludeBefore=2024-12-11&filter=isDisabled eq false
Sample Response
Related Issue
Merge After