Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app" #666

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Revert "Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app" #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9270776
Revert "Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntro…
mpmadhavig Aug 28, 2024
be5f3f6
Bump oauth version.
mpmadhavig Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 1 addition & 48 deletions ...wso2/carbon/identity/api/server/application/management/v1/OpenIDConnectConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ public static StateEnum fromValue(String value) {
private RefreshTokenConfiguration refreshToken;
private SubjectTokenConfiguration subjectToken;
private IdTokenConfiguration idToken;
private Boolean useClientIdAsSubClaimForAppTokens;
private Boolean omitUsernameInIntrospectionRespForAppTokens;
private OIDCLogoutConfiguration logout;
private Boolean validateRequestObjectSignature = false;
private List<String> scopeValidators = null;
Expand Down Expand Up @@ -360,45 +358,6 @@ public void setIdToken(IdTokenConfiguration idToken) {
this.idToken = idToken;
}

/**
* If enabled, client_id will be sent as the subject claim value for app tokens.
*/
public OpenIDConnectConfiguration useClientIdAsSubClaimForAppTokens(Boolean useClientIdAsSubClaimForAppTokens) {

this.useClientIdAsSubClaimForAppTokens = useClientIdAsSubClaimForAppTokens;
return this;
}

@ApiModelProperty("If enable, client_id will be sent as the sub claim value for app tokens.")
@JsonProperty("useClientIdAsSubClaimForAppTokens")
@Valid
public Boolean getUseClientIdAsSubClaimForAppTokens() {
return useClientIdAsSubClaimForAppTokens;
}
public void setUseClientIdAsSubClaimForAppTokens(Boolean useClientIdAsSubClaimForAppTokens) {
this.useClientIdAsSubClaimForAppTokens = useClientIdAsSubClaimForAppTokens;
}

/**
* If enabled, username will not be sent in the introspection response for app tokens.
*/
public OpenIDConnectConfiguration omitUsernameInIntrospectionRespForAppTokens(
Boolean omitUsernameInIntrospectionRespForAppTokens) {

this.omitUsernameInIntrospectionRespForAppTokens = omitUsernameInIntrospectionRespForAppTokens;
return this;
}

@ApiModelProperty("If enabled, username will not be sent in the introspection response for app tokens.")
@JsonProperty("omitUsernameInIntrospectionRespForAppTokens")
@Valid
public Boolean getOmitUsernameInIntrospectionRespForAppTokens() {
return omitUsernameInIntrospectionRespForAppTokens;
}
public void setOmitUsernameInIntrospectionRespForAppTokens(Boolean omitUsernameInIntrospectionRespForAppTokens) {
this.omitUsernameInIntrospectionRespForAppTokens = omitUsernameInIntrospectionRespForAppTokens;
}

/**
**/
public OpenIDConnectConfiguration logout(OIDCLogoutConfiguration logout) {
Expand Down Expand Up @@ -593,10 +552,6 @@ public boolean equals(java.lang.Object o) {
Objects.equals(this.refreshToken, openIDConnectConfiguration.refreshToken) &&
Objects.equals(this.subjectToken, openIDConnectConfiguration.subjectToken) &&
Objects.equals(this.idToken, openIDConnectConfiguration.idToken) &&
Objects.equals(this.useClientIdAsSubClaimForAppTokens,
openIDConnectConfiguration.useClientIdAsSubClaimForAppTokens) &&
Objects.equals(this.omitUsernameInIntrospectionRespForAppTokens,
openIDConnectConfiguration.omitUsernameInIntrospectionRespForAppTokens) &&
Objects.equals(this.logout, openIDConnectConfiguration.logout) &&
Objects.equals(this.validateRequestObjectSignature, openIDConnectConfiguration.validateRequestObjectSignature) &&
Objects.equals(this.scopeValidators, openIDConnectConfiguration.scopeValidators) &&
Expand All @@ -611,7 +566,7 @@ public boolean equals(java.lang.Object o) {
@Override
public int hashCode() {

return Objects.hash(clientId, clientSecret, state, grantTypes, callbackURLs, allowedOrigins, publicClient, pkce, hybridFlow, accessToken, refreshToken, subjectToken, idToken, useClientIdAsSubClaimForAppTokens, omitUsernameInIntrospectionRespForAppTokens, logout, validateRequestObjectSignature, scopeValidators, clientAuthentication, requestObject, pushAuthorizationRequest, subject, isFAPIApplication, fapiMetadata);
return Objects.hash(clientId, clientSecret, state, grantTypes, callbackURLs, allowedOrigins, publicClient, pkce, hybridFlow, accessToken, refreshToken, subjectToken, idToken, logout, validateRequestObjectSignature, scopeValidators, clientAuthentication, requestObject, pushAuthorizationRequest, subject, isFAPIApplication, fapiMetadata);
}

@Override
Expand All @@ -633,8 +588,6 @@ public String toString() {
sb.append(" refreshToken: ").append(toIndentedString(refreshToken)).append("\n");
sb.append(" subjectToken: ").append(toIndentedString(subjectToken)).append("\n");
sb.append(" idToken: ").append(toIndentedString(idToken)).append("\n");
sb.append(" useClientIdAsSubClaimForAppTokens: ").append(toIndentedString(useClientIdAsSubClaimForAppTokens)).append("\n");
sb.append(" omitUsernameInIntrospectionRespForAppTokens: ").append(toIndentedString(omitUsernameInIntrospectionRespForAppTokens)).append("\n");
sb.append(" logout: ").append(toIndentedString(logout)).append("\n");
sb.append(" validateRequestObjectSignature: ").append(toIndentedString(validateRequestObjectSignature)).append("\n");
sb.append(" scopeValidators: ").append(toIndentedString(scopeValidators)).append("\n");
Expand Down
4 changes: 0 additions & 4 deletions ...n/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ public OAuthConsumerAppDTO apply(String appName, OpenIDConnectConfiguration oidc
consumerAppDTO.setBypassClientCredentials(oidcModel.getPublicClient());
consumerAppDTO.setRequestObjectSignatureValidationEnabled(oidcModel.getValidateRequestObjectSignature());

consumerAppDTO.setUseClientIdAsSubClaimForAppTokens(oidcModel.getUseClientIdAsSubClaimForAppTokens());
consumerAppDTO.setOmitUsernameInIntrospectionRespForAppTokens(
oidcModel.getOmitUsernameInIntrospectionRespForAppTokens());

updateAllowedOrigins(consumerAppDTO, oidcModel.getAllowedOrigins());
updatePkceConfigurations(consumerAppDTO, oidcModel.getPkce());
updateHybridFlowConfigurations(consumerAppDTO, oidcModel.getHybridFlow());
Expand Down
3 changes: 0 additions & 3 deletions ...n/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ public OpenIDConnectConfiguration apply(OAuthConsumerAppDTO oauthAppDTO) {
.accessToken(buildTokenConfiguration(oauthAppDTO))
.refreshToken(buildRefreshTokenConfiguration(oauthAppDTO))
.idToken(buildIdTokenConfiguration(oauthAppDTO))
.useClientIdAsSubClaimForAppTokens(oauthAppDTO.isUseClientIdAsSubClaimForAppTokens())
.omitUsernameInIntrospectionRespForAppTokens(
oauthAppDTO.isOmitUsernameInIntrospectionRespForAppTokens())
.logout(buildLogoutConfiguration(oauthAppDTO))
.scopeValidators(getScopeValidators(oauthAppDTO))
.validateRequestObjectSignature(oauthAppDTO.isRequestObjectSignatureValidationEnabled())
Expand Down
6 changes: 0 additions & 6 deletions ...carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3603,12 +3603,6 @@ components:
Enabling this option will allow the client to authenticate without a
client secret.
example: false
useClientIdAsSubClaimForAppTokens:
type: boolean
description: If enabled, client_id will be sent as the sub claim value for app tokens.
omitUsernameInIntrospectionRespForAppTokens:
type: boolean
description: If enabled, username will not be sent in the introspection response for app tokens.
pkce:
$ref: '#/components/schemas/OAuth2PKCEConfiguration'
accessToken:
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@
<findsecbugs-plugin.version>1.12.0</findsecbugs-plugin.version>
<maven.checkstyleplugin.excludes>**/gen/**/*</maven.checkstyleplugin.excludes>
<identity.event.handler.version>1.8.19</identity.event.handler.version>
<identity.inbound.oauth2.version>7.0.140</identity.inbound.oauth2.version>
<identity.inbound.oauth2.version>7.0.154</identity.inbound.oauth2.version>
<identity.inbound.saml2.version>5.11.41</identity.inbound.saml2.version>
<commons.beanutils.version>1.9.4</commons.beanutils.version>
<mavan.findbugsplugin.exclude.file>findbugs-exclude-filter.xml</mavan.findbugsplugin.exclude.file>
Expand Down
Loading