Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to associate v2 roles with applications #504

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Add capability to associate v2 roles with applications #504

merged 4 commits into from
Oct 24, 2023

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Oct 15, 2023 •
edited
Loading

Purpose

$Subject

Application Creation:
Screenshot 2023-10-15 at 19 54 30

Application update:
Screenshot 2023-10-15 at 19 55 17

Application Retrieval:

Screenshot 2023-10-15 at 19 54 52

Depends on:

@AnuradhaSK AnuradhaSK mentioned this pull request Oct 15, 2023
Closed
@AnuradhaSK AnuradhaSK marked this pull request as ready for review October 23, 2023 10:29
thanujalk
thanujalk previously approved these changes Oct 23, 2023
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6614576822

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6614576822
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6617488021

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6617488021
Status: failure

@AnuradhaSK
Copy link
Contributor Author

Failure is

[ERROR] Tests run: 2068, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6,329.786 s <<< FAILURE! - in TestSuite
[ERROR] testSAMLSSOLogin(org.wso2.identity.integration.test.saml.RegistryMountTestCase)  Time elapsed: 7.306 s  <<< FAILURE!
java.lang.AssertionError: SAML SSO Login failed for travelocity.com-registrymount expected:<true> but was:<false>
	at org.wso2.identity.integration.test.saml.RegistryMountTestCase.testSAMLSSOLogin(RegistryMountTestCase.java:172)

Which is locally passing. Hence merging

@AnuradhaSK AnuradhaSK merged commit 7852132 into wso2:master Oct 24, 2023
4 checks passed
@AnuradhaSK AnuradhaSK deleted the role-association branch October 24, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashimalcse shashimalcse shashimalcse approved these changes

@thanujalk thanujalk thanujalk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnuradhaSK @jenkins-is-staging @thanujalk @shashimalcse