Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest endpoint for Remote Server Logging #485

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Rest endpoint for Remote Server Logging #485

merged 3 commits into from
Sep 7, 2023

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Sep 5, 2023 •
edited
Loading

Purpose

Fixes wso2/product-is#16588

Prerequestie

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

madurangasiriwardena
madurangasiriwardena reviewed Sep 6, 2023
View reviewed changes
...n/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceHolder.java
*/
public RemoteLoggingConfigService getRemoteLoggingConfigService() {

return ConfigsServiceHolder.getInstance().remoteLoggingConfigService;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be this.remoteLoggingConfigService ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are fine, but the suggestion is more appropriate.

...nfigs.common/src/main/java/org/wso2/carbon/identity/api/server/configs/common/Constants.java Outdated Show resolved Hide resolved
.../wso2/carbon/identity/api/server/configs/common/factory/RemoteLoggingOGSiServiceFactory.java Outdated Show resolved Hide resolved
madurangasiriwardena
madurangasiriwardena reviewed Sep 6, 2023
View reviewed changes
...n/src/main/java/org/wso2/carbon/identity/api/server/configs/common/ConfigsServiceHolder.java
*/
public void setRemoteLoggingConfigService(RemoteLoggingConfigService remoteLoggingConfigService) {

ConfigsServiceHolder.getInstance().remoteLoggingConfigService = remoteLoggingConfigService;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ConfigsServiceHolder.getInstance().remoteLoggingConfigService = remoteLoggingConfigService;
this.remoteLoggingConfigService = remoteLoggingConfigService;

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6095550388

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6095550388
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6098038878

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6098038878
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6104800783

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6104800783
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Sep 7, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6104800783

@Thumimku Thumimku merged commit 7692ed2 into wso2:master Sep 7, 2023
3 checks passed
@divyaamunugama divyaamunugama mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@madurangasiriwardena madurangasiriwardena madurangasiriwardena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Adding REST API for Remote Logging
4 participants
@Thumimku @CLAassistant @jenkins-is-staging @madurangasiriwardena