-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API endpoint for patching multiple governance connectors #476
Merged
Kanapriya
merged 5 commits into
wso2:master
from
Lakshan-Banneheke:patch-governance-connectors
Aug 29, 2023
Merged
Add API endpoint for patching multiple governance connectors #476
Kanapriya
merged 5 commits into
wso2:master
from
Lakshan-Banneheke:patch-governance-connectors
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lakshan-Banneheke
force-pushed
the
patch-governance-connectors
branch
2 times, most recently
from
August 22, 2023 05:45
e432932
to
0bbb26a
Compare
Lakshan-Banneheke
force-pushed
the
patch-governance-connectors
branch
from
August 23, 2023 06:01
0bbb26a
to
7188336
Compare
Kanapriya
reviewed
Aug 24, 2023
...n/java/org/wso2/carbon/identity/api/server/identity/governance/v1/IdentityGovernanceApi.java
Outdated
Show resolved
Hide resolved
...org/wso2/carbon/identity/api/server/identity/governance/v1/IdentityGovernanceApiService.java
Show resolved
Hide resolved
.../carbon/identity/api/server/identity/governance/v1/core/ServerIdentityGovernanceService.java
Show resolved
Hide resolved
Kanapriya
previously approved these changes
Aug 24, 2023
DMHP
reviewed
Aug 25, 2023
.../carbon/identity/api/server/identity/governance/v1/core/ServerIdentityGovernanceService.java
Outdated
Show resolved
Hide resolved
DMHP
reviewed
Aug 25, 2023
.../carbon/identity/api/server/identity/governance/v1/core/ServerIdentityGovernanceService.java
Show resolved
Hide resolved
DMHP
approved these changes
Aug 29, 2023
Kanapriya
approved these changes
Aug 29, 2023
ayeshajay
reviewed
Feb 18, 2024
...n/java/org/wso2/carbon/identity/api/server/identity/governance/v1/IdentityGovernanceApi.java
Show resolved
Hide resolved
.../gen/java/org/wso2/carbon/identity/api/server/identity/governance/v1/model/ConnectorReq.java
Show resolved
Hide resolved
.../gen/java/org/wso2/carbon/identity/api/server/identity/governance/v1/model/ConnectorReq.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There is a requirement to have an API endpoint for updating configurations of multiple governance connectors.
Currently, multiple patch requests need to be sent to the identity governance api for each connector simultaneously, and this is causing some updates to get lost due to a race condition.
The password expiry and password history connectors are updated using one button from the frontend, which sends multiple patch requests which causes this problem.
The PR resolves https://github.com/wso2-enterprise/asgardeo-product/issues/18833
Goals
Approach
/identity-governance/{category-id}/connectors
.Sample request body.
Automation tests
Integration tests
Security checks
Related Issues