Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve framework to skip retry from authenticator #6334

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZiyamSanthosh
Copy link
Contributor

Currently, if an authenticator fails, the reason for the failure will be shown when the authenticator is re-executed. For this, the authenticator depends on the retryAuthenticationEnabled function. The resend mechanism also depends on the same method. For scenarios where the user denies the authentication flow from the authenticator, the user has to be redirected to the application with an error message without retrying the authenticator.

This improvement addresses the above mentioned concern.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.48%. Comparing base (00f745a) to head (4fa8d4c).
Report is 307 commits behind head on master.

Files with missing lines Patch % Lines
...on/framework/AbstractApplicationAuthenticator.java 0.00% 0 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6334      +/-   ##
============================================
+ Coverage     45.31%   45.48%   +0.16%     
- Complexity    14544    15266     +722     
============================================
  Files          1656     1697      +41     
  Lines        104431   110450    +6019     
  Branches      18372    19669    +1297     
============================================
+ Hits          47324    50237    +2913     
- Misses        50288    53085    +2797     
- Partials       6819     7128     +309     
Flag Coverage Δ
unit 29.90% <0.00%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiyamSanthosh
Copy link
Contributor Author

To cover the newly added lines, AbstractAppAuthSkipRetryTest.java was introduced. Even though the tests covers the new lines, Codecov is not detecting it. I have locally checked that the test are covering the new lines added.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12945680845

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12945680845
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants