Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new Identity Context to the carbon core #6325

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Jan 22, 2025

Proposed changes in this pull request

This PR will add a new Identity Context in carbon identity core.
It will use a separate DataHolder to store the data needed to store in the context.
Also this will have read access to the CarbonContextDataHolder as well.

Related Issue

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12944976468

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 113 lines in your changes missing coverage. Please review.

Project coverage is 46.27%. Comparing base (631952a) to head (afed8c7).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/core/context/model/ApplicationActor.java 0.00% 29 Missing ⚠️
.../carbon/identity/core/context/IdentityContext.java 0.00% 25 Missing ⚠️
.../wso2/carbon/identity/core/context/model/Flow.java 0.00% 22 Missing ⚠️
...ntity/core/internal/IdentityContextDataHolder.java 0.00% 14 Missing ⚠️
.../carbon/identity/core/context/model/UserActor.java 0.00% 12 Missing ⚠️
...ore/context/valve/IdentityContextCreatorValve.java 0.00% 11 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6325      +/-   ##
============================================
- Coverage     46.55%   46.27%   -0.28%     
+ Complexity    14743    14711      -32     
============================================
  Files          1701     1701              
  Lines        103346   104272     +926     
  Branches      18558    18338     -220     
============================================
+ Hits          48109    48257     +148     
- Misses        48377    49164     +787     
+ Partials       6860     6851       -9     
Flag Coverage Δ
unit 29.84% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12944976468
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants