Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new authenticator configs for user defined authentication extensions. #6108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Nov 6, 2024

Issue:

With this PR, following changes will be added.

  • Introduced new authenticator configuration UserDefinedFederatedAuthenticator model to for user defined fed authenticators extending FederatedAuthenticatorConfig class.
  • Introduced new authenticator configuration UserDefinedLocalAuthenticator model to for user defined fed authenticators extending LocalAuthenticatorConfig class.

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-user-defined-auth-config branch 3 times, most recently from 1e739c9 to b57cbda Compare November 6, 2024 09:33
@Thisara-Welmilla Thisara-Welmilla requested review from Yoshani and removed request for Yoshani November 6, 2024 09:52
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.

Project coverage is 40.76%. Comparing base (c0ba5cc) to head (020a81a).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...mmon/model/AuthenticatorEndpointConfiguration.java 80.00% 7 Missing and 1 partial ⚠️
...model/UserDefinedFederatedAuthenticatorConfig.java 57.14% 3 Missing ⚠️
...mon/model/UserDefinedLocalAuthenticatorConfig.java 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6108      +/-   ##
============================================
- Coverage     40.98%   40.76%   -0.22%     
+ Complexity    14698    14490     -208     
============================================
  Files          1764     1768       +4     
  Lines        119164   117721    -1443     
  Branches      20860    20305     -555     
============================================
- Hits          48836    47992     -844     
+ Misses        63008    62453     -555     
+ Partials       7320     7276      -44     
Flag Coverage Δ
unit 25.04% <77.41%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant