Fix issue with disabled IDP getting picked for fidp parameter #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
Lakshan-Banneheke
force-pushed
the
fidp
branch
3 times, most recently
from
d99d8ff
to
6c11fc5
Compare
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
Lakshan-Banneheke
force-pushed
the
fidp
branch
from
17b4f9e
to
cae2b8a
Compare
...-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java
Show resolved
Hide resolved
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
Lakshan-Banneheke
force-pushed
the
fidp
branch
from
cae2b8a
to
f32a04f
Compare
sahandilshan
previously approved these changes
Oct 13, 2023
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
Lakshan-Banneheke
force-pushed
the
fidp
branch
from
f32a04f
to
056e029
Compare
|
PR builder started |
asha15
reviewed
Oct 13, 2023
...-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6505901883
asha15
reviewed
Oct 13, 2023
...-mgt/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAO.java
Outdated
Show resolved
Hide resolved
Lakshan-Banneheke
force-pushed
the
fidp
branch
from
056e029
to
bcbb83d
Compare
|
PR builder started |
Lakshan-Banneheke
force-pushed
the
fidp
branch
from
bcbb83d
to
34ef5cb
Compare
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6516173145
asha15
previously approved these changes
Oct 15, 2023
pamodaaw
reviewed
Oct 16, 2023
...g.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/util/IdPManagementConstants.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 16, 2023
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 16, 2023
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 16, 2023
...t/org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/IdentityProviderManager.java
Outdated
Show resolved
Hide resolved
pamodaaw
approved these changes
Oct 17, 2023
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6542713567
ayeshajay
reviewed
Feb 18, 2024
.../org.wso2.carbon.idp.mgt/src/main/java/org/wso2/carbon/idp/mgt/dao/CacheBackedIdPMgtDAO.java
Show resolved
Hide resolved
.../org.wso2.carbon.idp.mgt/src/test/java/org/wso2/carbon/idp/mgt/dao/IdPManagementDAOTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Only enabled IDPs will be retrieved from the database when using fidp parameter
Resolves issue: wso2/product-is#16351