Resolve hostname verification issue with localhost in self registration flow. #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2023
LakshiAthapaththu
force-pushed
the
http_cleint_issue
branch
from
e3df259
to
db3ab4e
Compare
chamathns
approved these changes
Jul 19, 2023
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5607017989
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This PR resolves the issue of internal API calls failing when localhost is not added as a SAN as mentioned in wso2/product-is#16181. The flow is modified to use an HTTP client with a custom verifier introduced in wso2/carbon-kernel#3610 accordingly.
When should this PR be merged
This should be merged only after wso2/carbon-kernel#3610 is merged and relevant dependency is added accordingly.