Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute profiles properties to schema response. #596

Merged

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Jan 19, 2025

Purpose

  • Add attribute profiles related properties as JSON object to scim2/Schemas response.
  • Introduce the global supportedByDefault property. Previously, only attributes marked as supportedByDefault were returned in the response. Now, any profiles with supportedByDefault set to true will also be included.
image

Related Issues

Related PRs

@PasinduYeshan PasinduYeshan marked this pull request as ready for review January 20, 2025 06:53
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (9373bdf) to head (1dfc576).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...on/identity/scim2/common/impl/SCIMUserManager.java 92.30% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #596      +/-   ##
============================================
+ Coverage     40.05%   40.60%   +0.55%     
+ Complexity     1087      874     -213     
============================================
  Files            41       41              
  Lines         10481    10518      +37     
  Branches       2647     2659      +12     
============================================
+ Hits           4198     4271      +73     
+ Misses         5349     5309      -40     
- Partials        934      938       +4     
Flag Coverage Δ
unit 30.32% <92.30%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12866686512

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12866686512
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12866686512

@PasinduYeshan PasinduYeshan merged commit 59610b6 into wso2-extensions:master Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants