Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCIM System Schema #594

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

@amanda-ariyaratne amanda-ariyaratne commented Jan 16, 2025

Purpose

This pull request introduces support for a new SCIM system schema extension within the WSO2 Identity Server. The changes include schema definition updates, logic enhancements for schema processing, and test coverage to validate the new functionality.

Related Issues

@amanda-ariyaratne amanda-ariyaratne force-pushed the master branch 5 times, most recently from aa306c0 to b8104ea Compare January 20, 2025 09:33
@amanda-ariyaratne
Copy link
Contributor Author

The integration tests were run locally with the changes in following PRs.

  1. Add SCIM System Schema wso2/charon#418
  2. Move attributes to system schema wso2/carbon-identity-framework#6336
  3. Add SCIM System Schema #594
  4. Fix integration tests for system and custom schema wso2/product-is#22361

We can merge PRs 1, 2 & 3 and bump their versions in PR 4 and run the integration tests again. Since they are dependent, running the PR builder alone is expected to fail the integration tests.

Screenshot 2025-01-22 at 21 36 19

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 29.76190% with 59 lines in your changes missing coverage. Please review.

Project coverage is 47.23%. Comparing base (a8d4a2e) to head (7a010f4).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...on/identity/scim2/common/impl/SCIMUserManager.java 49.01% 18 Missing and 8 partials ⚠️
...mmon/impl/IdentityResourceTypeResourceManager.java 0.00% 16 Missing ⚠️
...n/identity/scim2/common/utils/SCIMCommonUtils.java 0.00% 15 Missing ⚠️
...ity/scim2/common/internal/SCIMCommonComponent.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #594      +/-   ##
============================================
- Coverage     47.43%   47.23%   -0.20%     
+ Complexity     1120     1039      -81     
============================================
  Files            41       41              
  Lines          9065     9120      +55     
  Branches       2339     2352      +13     
============================================
+ Hits           4300     4308       +8     
- Misses         3838     3878      +40     
- Partials        927      934       +7     
Flag Coverage Δ
unit 32.92% <29.76%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amanda-ariyaratne amanda-ariyaratne merged commit 64bdb0e into wso2-extensions:master Jan 23, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants