Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty check before updating IDP groups #554

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add empty check before updating IDP groups #554

merged 1 commit into from
Jun 6, 2024

Conversation

SujanSanjula96
Copy link
Contributor

Currently we do not have an empty check before updating IDP groups during role creation. Due to this IDP group update event is triggered unnecessarily. This PR add an additional empty check before updating IDP groups

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9406177473

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9406177478

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9406177473
Status: cancelled

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9406177478
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jun 6, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/9406177478

@SujanSanjula96 SujanSanjula96 merged commit 332d91e into wso2-extensions:master Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@ShanChathusanda93 ShanChathusanda93 ShanChathusanda93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SujanSanjula96 @jenkins-is-staging @ShanChathusanda93