Fixed userstore resolving logic for tenant #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This pull request includes changes to the
AttributeCallbackHandler.javafile to improve the handling of user claims and error scenarios. The most important changes include updating the method for obtaining theUserRealmand adding an additional catch block forIdentityException.Improvements to user claims handling:
components/org.wso2.carbon.security.sts.common/src/main/java/org/wso2/carbon/identity/sts/common/identity/provider/AttributeCallbackHandler.java: Updated the method for obtaining theUserRealmby usingIdentityTenantUtil.getRealmwith the tenant domain obtained from the thread local context. This change ensures that the correct tenant domain is used when retrieving user claims.Error handling enhancements:
components/org.wso2.carbon.security.sts.common/src/main/java/org/wso2/carbon/identity/sts/common/identity/provider/AttributeCallbackHandler.java: Added a new catch block forIdentityExceptionto handle additional error scenarios when loading claims. This improves the robustness of the error handling in thehandlemethod.