Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics logs to action execution #2596

Conversation

osandamaleesha
Copy link
Contributor

@osandamaleesha osandamaleesha commented Oct 16, 2024

Proposed changes in this pull request

This PR adds diagnostic logs to action execution flow to enhance the troubleshooting capabilities for the extension developer.

Related issues

Examples

  • The proposed diagnostics logs printed in IS server are addressed against an existing flow in Asgardeo by correlating the corresponding log element.

  • INFO : [6] denotes configuration parameters and [7] denotes input parameters

IS server logs
Screenshot from 2024-10-17 11-50-40

Asgardeo diagnostic logs
Screenshot from 2024-10-17 11-52-29

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ RushanNanayakkara
✅ osandamaleesha
✅ Thisara-Welmilla
✅ DMHP
✅ DilshanSenarath
❌ wso2-jenkins-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 56.12%. Comparing base (5c3c468) to head (eff82ac).

Files with missing lines Patch % Lines
...h/action/PreIssueAccessTokenResponseProcessor.java 0.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2596      +/-   ##
============================================
- Coverage     56.13%   56.12%   -0.02%     
+ Complexity     8097     8087      -10     
============================================
  Files           632      632              
  Lines         46049    46066      +17     
  Branches       7524     7525       +1     
============================================
+ Hits          25850    25853       +3     
- Misses        16478    16493      +15     
+ Partials       3721     3720       -1     
Flag Coverage Δ
unit 38.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osandamaleesha osandamaleesha force-pushed the test/diagnosticsLogs branch 7 times, most recently from d59114c to 0cbc1dd Compare October 22, 2024 07:59
@osandamaleesha
Copy link
Contributor Author

Duplicate PR at #2603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants