Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address multiple users exist in different user stores when recovering username #906

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Jan 10, 2025

Proposed changes in this pull request

Related Issues

As the default email template is configured as below, receive multiple emails with domain qualified usernames.

<b>{{userstore-domain}}/{{user-name}}</b>
Screenshot 2025-01-10 at 14 43 15 Screenshot 2025-01-10 at 14 43 29

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 51.02%. Comparing base (55bf5a4) to head (6c38590).

Files with missing lines Patch % Lines
...ice/impl/username/UsernameRecoveryManagerImpl.java 55.55% 2 Missing and 2 partials ⚠️
.../org/wso2/carbon/identity/recovery/util/Utils.java 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #906      +/-   ##
============================================
+ Coverage     50.91%   51.02%   +0.11%     
- Complexity     2431     2435       +4     
============================================
  Files           298      298              
  Lines         17979    17995      +16     
  Branches       2585     2590       +5     
============================================
+ Hits           9154     9182      +28     
+ Misses         7673     7655      -18     
- Partials       1152     1158       +6     
Flag Coverage Δ
unit 38.54% <60.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12708280884

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12708280884
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12708280884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants