Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datamart): use GFW Data API datamart #4848

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gtempus
Copy link

@gtempus gtempus commented Sep 6, 2024

Overview

I'll add more information next week!

Use the GFW Data API data mart.
It's currently at:
http://gfw-data-api-elb-shared-dev-lb-10091095.us-east-1.elb.amazonaws.com:30616/#tag/Forest-Change-Analysis

Update the server-side dataMartRequest URL configuration to try it out!

Notes

I split the code by adding two helper functions depending on isDownload. I wanted to be able to show the extreme difference between the two approaches. The GFW Data API data mart makes for a much more straightforward interface.

@jterry64
Copy link
Member

jterry64 commented Sep 6, 2024

@gtempus just to make sure I understand, you're trying to highlight the difference between get_net_tree_cover_change_results and get_net_tree_cover_change_download_url, where the former uses the data mart, and the latter uses the existing method?

@gtempus
Copy link
Author

gtempus commented Sep 9, 2024

Yes, @jterry64. I was commenting that since we don't have the download endpoint implemented, it's easy to see how the data mart simplifies the integration between Data API and Flagship.

@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4848 October 7, 2024 22:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants