Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01-Creating-and-Managing-Custom-Tables.md #14

Conversation

jonathanbossenger
Copy link
Collaborator

@jonathanbossenger jonathanbossenger commented Oct 8, 2024

@MichelleBlanchette

I am creating a new PR with my suggested changes to this lesson. I had wanted to use the GitHub PR review UI to leave comments and suggestions, but I was working offline. I'll try and do that for future scripts.

I'm going to summarize my review feedback in the comments, but feel free to discuss any of the changes with me.

General feedback, an excellent draft, thank you for your hard work on this lesson.

Specific feedback:

  1. We (the training team) try to create the lessons so that they can be viewed both as part of a module/course, but also as a stand alone piece of content. So we generally try and stay away from more direct references to the lesson belonging to a specific module, and instead of referring to "in the next lesson" or "in the previous lesson" and instead refer to the lessons by their title.
  2. With all code examples, I like to try and create examples that are more close to something someone might actually use in the real world.
  3. Much of the rest of the changes are really just clarifications of certain things, or referring to things correctly (eg the WPDB class vs the $wpdb object instance).
  4. I like to try and include as any "further reading" links back to documentation as part of the lesson summary.
  5. I am happy to discuss any of the changes I've suggested

Copy link
Collaborator

@MichelleBlanchette MichelleBlanchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jonathanbossenger ! This all makes total sense, and I greatly appreciate the changes. When looking through, I realized some other improvements that could be made.

Also, thank you for remaking the example code to be about basic form submissions because I have had such creative block and that kept bothering me, yet the answer was so simple all this time. 😂

@jonathanbossenger
Copy link
Collaborator Author

This all makes total sense, and I greatly appreciate the changes. When looking through, I realized some other improvements that could be made.

Excellent, I'm glad the suggestions where useful. I'm working through your feedback today.

Also, thank you for remaking the example code to be about basic form submissions because I have had such creative block and that kept bothering me, yet the answer was so simple all this time. 😂

No problem at all. Honestly, I have a similar struggle myself; I will often agonize for days over the code examples. I'm glad that we're able to collaborate on this.

@jonathanbossenger
Copy link
Collaborator Author

@MichelleBlanchette I've either updated the lesson based on your feedback, or left responses where further discussion is needed. Looking forward to your continued feedback.

@jonathanbossenger
Copy link
Collaborator Author

@MichelleBlanchette to the best of my knowledge, all changes requested have been completed.

@MichelleBlanchette
Copy link
Collaborator

Thank you @jonathanbossenger ! I ran out of time to get to review and merge this today because I prioritized wrapping up the draft for Lesson 02 in this module.

I'll take a final look at this either tomorrow or Thursday. Thanks for your continued support (and patience)! 😁

Copy link
Collaborator

@MichelleBlanchette MichelleBlanchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanbossenger A couple more improvements I'd like to add, if you don't mind! 🙇

I cloned this branch then realized I didn't have commit permissions to do so (which makes sense!), so I needed to leave these few other tweaks as more change requests.

Thank you again! I'm hoping to record the audio and video for this lesson this weekend!

Your improvements and collaboration are really bringing this lesson to the highest quality it can be for fellow learners. I really appreciate it! 😃

@jonathanbossenger
Copy link
Collaborator Author

@MichelleBlanchette thank you for the additional update requests, I've committed them to the PR

I'm hoping to record the audio and video for this lesson this weekend!

Sounds good, I'll merge this now.

Your improvements and collaboration are really bringing this lesson to the highest quality it can be for fellow learners. I really appreciate it!

And I appreciate all your hard work in research, script writing, and collaborative review.

I look forward to seeing the first draft of the video!

@jonathanbossenger jonathanbossenger merged commit b9bed9e into main Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants