Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at adding cache clearing on post update #6

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kkoppenhaver
Copy link

@kkoppenhaver kkoppenhaver commented Nov 3, 2019

This addresses wptide/wptide#186

Currently the code in this branch runs when triggered manually, but doesn't seem to run in the current location in the plugin, so that will need to be debugged.

@jeffpaul
Copy link
Member

@pierlon as you're able, could you please help review this PR?

@jeffpaul jeffpaul added the enhancement New feature or request label Jan 21, 2020
@pierlon
Copy link

pierlon commented Jan 21, 2020

As @kkoppenhaver said above, the function when called directly does resolve the issue, but it seems the request is hitting the Redis cache before going to the API. If so, that needs to be resolved first.

@jeffpaul
Copy link
Member

@pierlon do we have an issue opened for that secondary issue that needs to be resolved first? If not, would you please open one?

@pierlon
Copy link

pierlon commented Jan 24, 2020

I haven't been able to exactly pinpoint the issue as yet but wptide/wptide#112 seems to be related to the caching issue here. I'll update this issue with my findings once I take another look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants