-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing text domains #32
base: develop
Are you sure you want to change the base?
Conversation
These changes look accurate to me. One thing I'm curious about that's mostly unrelated here is whether https://github.com/wptide/wp-tide-api/blob/develop/class-wp-tide-api.php should be renamed to wp-tide-api.php as the core plugin file so that it matches the repo/folder name (which is generally a standard for WP plugins)? |
@jeffpaul in most cases the more WordPress way would be to have a file named same as the slug which will load this file. This file will fail PHPCS sniff because it has a class. So best option is to create a new “plugin” file that contains the plugin header and modified of last two lines that initiates it. |
@akkspros any chance you're able to tackle the changes as noted via @rheinardkorf? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akkspros are you able to update this PR per the feedback above?
add missing text domains