Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing text domains #32

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add missing text domains #32

wants to merge 1 commit into from

Conversation

akkspros
Copy link
Contributor

@akkspros akkspros commented Feb 4, 2020

add missing text domains

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.873% when pulling 9e1eb2c on akkspros:akkspros into 1012502 on wptide:develop.

@akkspros akkspros requested review from derekherman and jeffpaul and removed request for derekherman February 4, 2020 13:10
@jeffpaul jeffpaul added this to the 1.0.0 milestone Feb 4, 2020
@jeffpaul
Copy link
Member

jeffpaul commented Feb 4, 2020

These changes look accurate to me. One thing I'm curious about that's mostly unrelated here is whether https://github.com/wptide/wp-tide-api/blob/develop/class-wp-tide-api.php should be renamed to wp-tide-api.php as the core plugin file so that it matches the repo/folder name (which is generally a standard for WP plugins)?

@rheinardkorf
Copy link
Contributor

@jeffpaul in most cases the more WordPress way would be to have a file named same as the slug which will load this file. This file will fail PHPCS sniff because it has a class. So best option is to create a new “plugin” file that contains the plugin header and modified of last two lines that initiates it.

@jeffpaul
Copy link
Member

@akkspros any chance you're able to tackle the changes as noted via @rheinardkorf?

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akkspros are you able to update this PR per the feedback above?

@akkspros
Copy link
Contributor Author

@akkspros are you able to update this PR per the feedback above?

Sorry @jeffpaul I can't able to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants