-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SAML authentication #253
Open
jwidavid
wants to merge
13
commits into
master
Choose a base branch
from
add/saml-authentication
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwidavid
force-pushed
the
add/saml-authentication
branch
from
May 26, 2024 03:17
240d74a
to
fb7e333
Compare
Can't really approve it since it's a draft state, but LGTM, we can probably go forward with the other ones and then merge them into this branch. |
Add SAML flag to follow the redirect and open the browser
Add authenticating onto client site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will serve as the base for several other PR's. As they get reviewed and approved, I will merge them into this one once the feature is a functioning MVP.
Testing Instructions
These specific instructions are dependent on being able to build and run the WPScan CLI Scanner locally (rather than through docker).
See: https://github.com/wpscanteam/wpscan
Update
wpscan/Gemfile
to add:gem 'cms_scanner', path: '/absolute-path-to-the-scanner/CMSScanner'
You may also need to comment the following line from the
wpscan.gemspec
:s.add_dependency 'cms_scanner', '~> 0.13.9'
--expect-saml
flaghttp://3.135.88.75/