Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UR-1057 Tweak - Improve success message after registration #618

Merged
merged 6 commits into from
Nov 30, 2023
Merged

UR-1057 Tweak - Improve success message after registration #618

merged 6 commits into from
Nov 30, 2023

Conversation

riteelama
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Previously the user registration notification was shown below the form. Now, We have shown the notification by removing the form on it.

How to test the changes in this Pull Request:

  1. Create a form
  2. Perform user registration with correct data
  3. Perform user registration by incorrect data(For eg: Creating user with same email address)
  4. Verify the notification message

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Tweak - Improve success message after registration

@riteelama riteelama self-assigned this Oct 19, 2023
iamprazol
iamprazol approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@iamprazol iamprazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

MILAN88888
MILAN88888 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

lekhnath005
lekhnath005 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@lekhnath005 lekhnath005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@iamprazol iamprazol merged commit 9eaef49 into develop Nov 30, 2023
1 check passed
@iamprazol iamprazol deleted the UR-1057-improve-success-message-after-registration branch November 30, 2023 07:49
iamprazol added a commit that referenced this pull request Dec 7, 2023
@iamprazol
Version bumo to 3.1.2 for internal release
7d7a85d 
Squashed commit of the following:

commit 1e19689
Author: Milan Chaudhary <[email protected]>
Date:   Thu Dec 7 09:27:53 2023 +0545

    Feature - Slot booking (#632)

    * Added - Slot booking settings

    * Dev - Feature slot booking

    * Fix - Slot booking in the edit profile

    * Fix - Backend validation and required field in the slot booking

    * Resolver PHPcs issues

    ---------

    Co-authored-by: Prajjwal Poudel <[email protected]>

commit 0fe1530
Author: Ranjan Khanal <[email protected]>
Date:   Wed Dec 6 16:17:49 2023 +0545

    Enhance - UR-1096 Length Feature Input and Textarea. (#630)

    * Validation for limit length and max length feature

    * Backend Validation and Add Frontend Validation Methods

    * Frontend Minimum Length Validation (Refactoring required)

    * Final commit.

    * Tweak - Solve PHP CS issues

    * Tweak2 - Solve PHP CS issues

    * Tweak3 - Solve PHP CS issues

    * Tweak4 - Solve PHP CS issues

    * Tweak4 - Solve PHP CS issues

    * Tweak - Fix Toggle option hide/show on first Drag

    * Tweak - Code refactoring for form-builder.

    * Fix - Compatibility issue for Size Input Field

    * Fix - Version change.

    * Tweak - Translations added.

    * Tweak - Translation ready and Delete unwanted code.

    * Add - Validation on edit profile.

    * Fix - Rtrim on backend Validation.

    * Fix - Server side validation for textarea field

    * Fix - Phpcs issues

    * Fix - Phpcs issues

    ---------

    Co-authored-by: Prajjwal Poudel <[email protected]>

commit b3b11ec
Author: Ritee Lama <[email protected]>
Date:   Wed Dec 6 15:49:47 2023 +0545

    UR-648 Tweak - Timepicker UI enhancement library change (#624)

    * Add - Timepicker ui enhancement library change

    * Add-TimePicker with range of start and end time

    * Add - Timepicker with range on edit profile form

    * Update - Required message updated on range enabled form submit

    * Update - Time setting according to time format

    * Update - Time picker with range styling and reuired error message

    * Fix - Timpicker class being added to every input field and properly enqueue flatpickr

    * Fix - Resolved phpcs issue

    * Fix - Resolved phpcs issue

    * Fix - phpcs issue

    * Fix1 - phpcs issue

    * Fix - Phpcs Issue Resolved

    * Add - Sync to pro

    * Add - Sync to pro

    * Update

    * Update sync

    * Updated

    * Updated

    * Fix - Phpcs issues

    * Fix - Phpcs issues

    * Sync code to pro

    * Update - Code Refactoring for CSS

    * Update - Code refactor for CSS

    * Update -Added div for ranged time picker

    * Fix - Server side validation message in non ajax profile update

    ---------

    Co-authored-by: Prajjwal Poudel <[email protected]>
    Co-authored-by: Milan Chaudhary <[email protected]>

commit 89fd483
Author: Prajjwal Poudel <[email protected]>
Date:   Tue Dec 5 12:47:04 2023 +0545

    Fix - all_fields smart tag parse to a table

commit 237baa2
Author: Lekhnath Pandey <[email protected]>
Date:   Tue Dec 5 09:06:41 2023 +0545

    Fix - MyAccount Page Translation issue

commit a9325d2
Author: Ritee Lama <[email protected]>
Date:   Mon Dec 4 22:30:53 2023 +0545

    UR-1228 Tweak - Need enhancement in send user approval link in email option (#622)

    * Add - Option to add approval link in email option

    * Update - Mail sent with approval link

    * Update - Approval link sent on email only if the approval link is enabled

    * Update - Enable email approval text and message

    * Update - Email approval and approval link text

    * Update - Approval hook name

    * Fix - Resolved the phpcs

commit 4ab656b
Author: Ranjan Khanal <[email protected]>
Date:   Mon Dec 4 22:29:29 2023 +0545

    UR-1045 Feature - Form Locate. (#623)

    * Form Locate feature

    * Fix - Escaping added.

    * Fix - phpcs issues.

    * Fix2 - phpcs issues.

    * Fix3 - phpcs issues.

commit a30ac90
Author: Lekhnath Pandey <[email protected]>
Date:   Mon Dec 4 08:10:09 2023 +0545

    Dev - Compatibility to display payment details (#631)

commit 5335556
Author: Prajjwal Poudel <[email protected]>
Date:   Thu Nov 30 16:15:44 2023 +0545

    Fix - Install user registration pages button not working

commit 9eaef49
Author: Ritee Lama <[email protected]>
Date:   Thu Nov 30 13:34:47 2023 +0545

    UR-1057 Tweak - Improve success message after registration (#618)

    * Update - Registration notificaion with form removed

    * Update - Error validation message display

    * Update - Error validation message display

    * Update - Notification refinement

    * Add - Select button to hide the form after successful submission

    * Update - Success message display text

commit 73004ef
Author: Ranjan Khanal <[email protected]>
Date:   Thu Nov 30 13:34:23 2023 +0545

    UR-1237 Enhancement - My account logout redirection to external url. (#619)

    * Redirection to external url through logout_redirect shortcode attribute

    * Added comments

    * Tweak - Added prefix to function name.

    * Tweak - Added function name on call.

    * Fix - Logout on Disable Logout Confirmation

    * Tweak - Fix PHP CS issues

    * Tweak2 - Fix PHP CS issues

    * Tweak3 - Fix PHP CS issues

    * Tweak4 - Fix PHP CS issues

    * Tweak5 - Fix PHP CS issues

    * Tweak6 - Fix PHPCS errors.

commit 5827b7b
Author: Milan Chaudhary <[email protected]>
Date:   Thu Nov 30 08:15:48 2023 +0545

    Dev - Form restriction addon (#621)

    * Dev - Form restriction addon

    * Added - To send the age restriction setting to post data

commit ace69ec
Author: Dipu chaudhary <[email protected]>
Date:   Wed Nov 29 07:59:41 2023 +0545

    Tweak - Validation error message in fields (#625)

commit 45ab4f2
Author: Lekhnath Pandey <[email protected]>
Date:   Mon Nov 27 09:08:21 2023 +0545

    Dev - Introduce hook to modify parse value for form data

commit 868b76d
Author: Lekhnath Pandey <[email protected]>
Date:   Mon Nov 27 08:49:07 2023 +0545

    Fix - Critical error while exporting user

commit 6e510ba
Author: Lekhnath Pandey <[email protected]>
Date:   Mon Nov 27 08:43:58 2023 +0545

    Dev - Remove No Prev ajax request for form save action

commit 1b7a73e
Author: Lekhnath Pandey <[email protected]>
Date:   Mon Nov 27 08:41:42 2023 +0545

    Fix - Translation issue with successfull email verified message

commit aeb21d1
Author: Lekhnath Pandey <[email protected]>
Date:   Mon Nov 27 07:08:08 2023 +0545

    Fix - Assign role conditionally not working in multisite (#614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lekhnath005 lekhnath005 lekhnath005 approved these changes

@iamprazol iamprazol iamprazol approved these changes

@MILAN88888 MILAN88888 MILAN88888 approved these changes

Assignees

@riteelama riteelama

Labels
Approved enhancement Merged Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riteelama @lekhnath005 @iamprazol @MILAN88888