Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UR-818 Fix - Submitting issue for conditionally hidden fields #589

Merged
merged 3 commits into from
Aug 30, 2023
Merged

UR-818 Fix - Submitting issue for conditionally hidden fields #589

merged 3 commits into from
Aug 30, 2023

Conversation

dipuchaudhary
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Previously, When the field is hidden conditionally though hidden field value is submitted while registering the user. This PR will fix this issue.

How to test the changes in this Pull Request:

  1. Go to the form builder and apply conditional logic to the field and update the form.
  2. Make registration and verify whether the conditionally hidden field value is submitted or not.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

UR-818 Fix - Submitting issue for conditionally hidden fields.

@dipuchaudhary dipuchaudhary self-assigned this Aug 16, 2023
salimshrestha98
salimshrestha98 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@salimshrestha98 salimshrestha98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

@iamprazol iamprazol requested review from iamprazol and removed request for lekhnath005 August 29, 2023 08:55
MILAN88888
MILAN88888 approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@MILAN88888 MILAN88888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

iamprazol
iamprazol approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@iamprazol iamprazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 👍

@iamprazol iamprazol merged commit a25272b into develop Aug 30, 2023
1 check passed
@iamprazol iamprazol deleted the UR-818-fix-submitting-issue-for-conditionally-hidden-fields branch August 30, 2023 06:05
iamprazol added a commit that referenced this pull request Aug 31, 2023
@iamprazol
Version bump to 3.0.4 for internal release
2f3cc4f 
Squashed commit of the following:

commit 7d40eaa
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 16:28:46 2023 +0545

    Feature - Cloudflare turnstile captcha integration (#596)

commit 7eda608
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 16:28:32 2023 +0545

    UR-1130 Fix - Incorrect filtering of pending users (#597)

    * Fix - User pending notice showing same number after denying users

    * Fix - Pending notice not showing

    * Fix - Pending filter showing denied users

    * Enhance - Add filter for Email Pending users

    * Fix - Denied users filter not working

commit 21eba06
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 30 16:28:03 2023 +0545

    Enhance - Option Enable/Disable taking picture from webcam (#592)

commit 3e568a8
Author: Milan Chaudhary <[email protected]>
Date:   Wed Aug 30 13:02:04 2023 +0545

    Enhancement - Create a menu to show the login form shortcode (#583)

    * Add - Login Forms tab

    * Fix - Login tabs list

    * Fix - Url issue

    * login shortcode page design fix

    * Add - Div wrapper

    * login shortcode design fix

    * login shortcode design fix

    * Added - Default active tab, notices area, copy icon

    * Add - Login Wrapper

    * login shortcode and form builder design fix

    * Fixed - Copy shortcode tooltips message, login form content

    ---------

    Co-authored-by: Ayush Shrestha <[email protected]>

commit a25272b
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 11:50:14 2023 +0545

    UR-818 Fix - Submitting issue for conditionally hidden fields (#589)

    * Fix - Submitting conditionally hidden fields

    * Code cleanup

    * Fix - conditionally hidden value submitting on hide/show multiple conditions

commit d0cb5c8
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 10:47:32 2023 +0545

    UR-1052 Enhance - Custom hold time before redirection after registration (#593)

    * Feature - Custom Hold period before redirection

    * Fix - Prevent negative input for wait time

commit c04ec96
Author: Salim Shrestha <[email protected]>
Date:   Tue Aug 29 14:43:52 2023 +0545

    Dev - Add filter to show extra user details to non admin

commit f672b89
Author: Dipu chaudhary <[email protected]>
Date:   Tue Aug 29 14:35:53 2023 +0545

    UR-573 Feature - Pattern validation for input fields (#588)

    * Added - Dependency of pattern validation

    * Toggle pattern option when enabled

    * Fix - concatenation of regex value

    * Fix - html element appending while selecting regex value

commit fff9803
Author: Lekhnath Pandey <[email protected]>
Date:   Tue Aug 29 13:27:54 2023 +0545

    UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591)

    * Fix - Invalid myaccount link while lost-password, logout, etc.

    * Fix - Email not been sent

    * Fix - Reset Password link throws invalid key

commit ccc5c2a
Author: Dipu chaudhary <[email protected]>
Date:   Mon Aug 28 12:37:43 2023 +0545

    UR-903 Tweak - Revamp deactivation pop items (#594)

    * Tweak - Revamp deactivation pop items

    * Open links in new tab

commit be73576
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:16:33 2023 +0545

    UR-1021 Fix - Other plugin notice displaying in our settings area

commit c64f8fc
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:14:32 2023 +0545

    UR-1127 Tweak - Corrected typos with addons url in readmeSquashed commit of the following:

commit 7d40eaa
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 16:28:46 2023 +0545

    Feature - Cloudflare turnstile captcha integration (#596)

commit 7eda608
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 16:28:32 2023 +0545

    UR-1130 Fix - Incorrect filtering of pending users (#597)

    * Fix - User pending notice showing same number after denying users

    * Fix - Pending notice not showing

    * Fix - Pending filter showing denied users

    * Enhance - Add filter for Email Pending users

    * Fix - Denied users filter not working

commit 21eba06
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 30 16:28:03 2023 +0545

    Enhance - Option Enable/Disable taking picture from webcam (#592)

commit 3e568a8
Author: Milan Chaudhary <[email protected]>
Date:   Wed Aug 30 13:02:04 2023 +0545

    Enhancement - Create a menu to show the login form shortcode (#583)

    * Add - Login Forms tab

    * Fix - Login tabs list

    * Fix - Url issue

    * login shortcode page design fix

    * Add - Div wrapper

    * login shortcode design fix

    * login shortcode design fix

    * Added - Default active tab, notices area, copy icon

    * Add - Login Wrapper

    * login shortcode and form builder design fix

    * Fixed - Copy shortcode tooltips message, login form content

    ---------

    Co-authored-by: Ayush Shrestha <[email protected]>

commit a25272b
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 11:50:14 2023 +0545

    UR-818 Fix - Submitting issue for conditionally hidden fields (#589)

    * Fix - Submitting conditionally hidden fields

    * Code cleanup

    * Fix - conditionally hidden value submitting on hide/show multiple conditions

commit d0cb5c8
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 10:47:32 2023 +0545

    UR-1052 Enhance - Custom hold time before redirection after registration (#593)

    * Feature - Custom Hold period before redirection

    * Fix - Prevent negative input for wait time

commit c04ec96
Author: Salim Shrestha <[email protected]>
Date:   Tue Aug 29 14:43:52 2023 +0545

    Dev - Add filter to show extra user details to non admin

commit f672b89
Author: Dipu chaudhary <[email protected]>
Date:   Tue Aug 29 14:35:53 2023 +0545

    UR-573 Feature - Pattern validation for input fields (#588)

    * Added - Dependency of pattern validation

    * Toggle pattern option when enabled

    * Fix - concatenation of regex value

    * Fix - html element appending while selecting regex value

commit fff9803
Author: Lekhnath Pandey <[email protected]>
Date:   Tue Aug 29 13:27:54 2023 +0545

    UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591)

    * Fix - Invalid myaccount link while lost-password, logout, etc.

    * Fix - Email not been sent

    * Fix - Reset Password link throws invalid key

commit ccc5c2a
Author: Dipu chaudhary <[email protected]>
Date:   Mon Aug 28 12:37:43 2023 +0545

    UR-903 Tweak - Revamp deactivation pop items (#594)

    * Tweak - Revamp deactivation pop items

    * Open links in new tab

commit be73576
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:16:33 2023 +0545

    UR-1021 Fix - Other plugin notice displaying in our settings area

commit c64f8fc
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:14:32 2023 +0545

    UR-1127 Tweak - Corrected typos with addons url in readme
iamprazol added a commit that referenced this pull request Aug 31, 2023
@iamprazol
Version bump to 3.0.4 for internal release
740df75 
Squashed commit of the following:

commit 7d40eaa
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 16:28:46 2023 +0545

    Feature - Cloudflare turnstile captcha integration (#596)

commit 7eda608
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 16:28:32 2023 +0545

    UR-1130 Fix - Incorrect filtering of pending users (#597)

    * Fix - User pending notice showing same number after denying users

    * Fix - Pending notice not showing

    * Fix - Pending filter showing denied users

    * Enhance - Add filter for Email Pending users

    * Fix - Denied users filter not working

commit 21eba06
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 30 16:28:03 2023 +0545

    Enhance - Option Enable/Disable taking picture from webcam (#592)

commit 3e568a8
Author: Milan Chaudhary <[email protected]>
Date:   Wed Aug 30 13:02:04 2023 +0545

    Enhancement - Create a menu to show the login form shortcode (#583)

    * Add - Login Forms tab

    * Fix - Login tabs list

    * Fix - Url issue

    * login shortcode page design fix

    * Add - Div wrapper

    * login shortcode design fix

    * login shortcode design fix

    * Added - Default active tab, notices area, copy icon

    * Add - Login Wrapper

    * login shortcode and form builder design fix

    * Fixed - Copy shortcode tooltips message, login form content

    ---------

    Co-authored-by: Ayush Shrestha <[email protected]>

commit a25272b
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 11:50:14 2023 +0545

    UR-818 Fix - Submitting issue for conditionally hidden fields (#589)

    * Fix - Submitting conditionally hidden fields

    * Code cleanup

    * Fix - conditionally hidden value submitting on hide/show multiple conditions

commit d0cb5c8
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 10:47:32 2023 +0545

    UR-1052 Enhance - Custom hold time before redirection after registration (#593)

    * Feature - Custom Hold period before redirection

    * Fix - Prevent negative input for wait time

commit c04ec96
Author: Salim Shrestha <[email protected]>
Date:   Tue Aug 29 14:43:52 2023 +0545

    Dev - Add filter to show extra user details to non admin

commit f672b89
Author: Dipu chaudhary <[email protected]>
Date:   Tue Aug 29 14:35:53 2023 +0545

    UR-573 Feature - Pattern validation for input fields (#588)

    * Added - Dependency of pattern validation

    * Toggle pattern option when enabled

    * Fix - concatenation of regex value

    * Fix - html element appending while selecting regex value

commit fff9803
Author: Lekhnath Pandey <[email protected]>
Date:   Tue Aug 29 13:27:54 2023 +0545

    UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591)

    * Fix - Invalid myaccount link while lost-password, logout, etc.

    * Fix - Email not been sent

    * Fix - Reset Password link throws invalid key

commit ccc5c2a
Author: Dipu chaudhary <[email protected]>
Date:   Mon Aug 28 12:37:43 2023 +0545

    UR-903 Tweak - Revamp deactivation pop items (#594)

    * Tweak - Revamp deactivation pop items

    * Open links in new tab

commit be73576
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:16:33 2023 +0545

    UR-1021 Fix - Other plugin notice displaying in our settings area

commit c64f8fc
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:14:32 2023 +0545

    UR-1127 Tweak - Corrected typos with addons url in readmeSquashed commit of the following:

commit 7d40eaa
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 16:28:46 2023 +0545

    Feature - Cloudflare turnstile captcha integration (#596)

commit 7eda608
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 16:28:32 2023 +0545

    UR-1130 Fix - Incorrect filtering of pending users (#597)

    * Fix - User pending notice showing same number after denying users

    * Fix - Pending notice not showing

    * Fix - Pending filter showing denied users

    * Enhance - Add filter for Email Pending users

    * Fix - Denied users filter not working

commit 21eba06
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 30 16:28:03 2023 +0545

    Enhance - Option Enable/Disable taking picture from webcam (#592)

commit 3e568a8
Author: Milan Chaudhary <[email protected]>
Date:   Wed Aug 30 13:02:04 2023 +0545

    Enhancement - Create a menu to show the login form shortcode (#583)

    * Add - Login Forms tab

    * Fix - Login tabs list

    * Fix - Url issue

    * login shortcode page design fix

    * Add - Div wrapper

    * login shortcode design fix

    * login shortcode design fix

    * Added - Default active tab, notices area, copy icon

    * Add - Login Wrapper

    * login shortcode and form builder design fix

    * Fixed - Copy shortcode tooltips message, login form content

    ---------

    Co-authored-by: Ayush Shrestha <[email protected]>

commit a25272b
Author: Dipu chaudhary <[email protected]>
Date:   Wed Aug 30 11:50:14 2023 +0545

    UR-818 Fix - Submitting issue for conditionally hidden fields (#589)

    * Fix - Submitting conditionally hidden fields

    * Code cleanup

    * Fix - conditionally hidden value submitting on hide/show multiple conditions

commit d0cb5c8
Author: Salim Shrestha <[email protected]>
Date:   Wed Aug 30 10:47:32 2023 +0545

    UR-1052 Enhance - Custom hold time before redirection after registration (#593)

    * Feature - Custom Hold period before redirection

    * Fix - Prevent negative input for wait time

commit c04ec96
Author: Salim Shrestha <[email protected]>
Date:   Tue Aug 29 14:43:52 2023 +0545

    Dev - Add filter to show extra user details to non admin

commit f672b89
Author: Dipu chaudhary <[email protected]>
Date:   Tue Aug 29 14:35:53 2023 +0545

    UR-573 Feature - Pattern validation for input fields (#588)

    * Added - Dependency of pattern validation

    * Toggle pattern option when enabled

    * Fix - concatenation of regex value

    * Fix - html element appending while selecting regex value

commit fff9803
Author: Lekhnath Pandey <[email protected]>
Date:   Tue Aug 29 13:27:54 2023 +0545

    UR-1132 Fix - Invalid Myaccount link for it's endpoints . (#591)

    * Fix - Invalid myaccount link while lost-password, logout, etc.

    * Fix - Email not been sent

    * Fix - Reset Password link throws invalid key

commit ccc5c2a
Author: Dipu chaudhary <[email protected]>
Date:   Mon Aug 28 12:37:43 2023 +0545

    UR-903 Tweak - Revamp deactivation pop items (#594)

    * Tweak - Revamp deactivation pop items

    * Open links in new tab

commit be73576
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:16:33 2023 +0545

    UR-1021 Fix - Other plugin notice displaying in our settings area

commit c64f8fc
Author: Prajjwal Poudel <[email protected]>
Date:   Wed Aug 23 10:14:32 2023 +0545

    UR-1127 Tweak - Corrected typos with addons url in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimshrestha98 salimshrestha98 salimshrestha98 approved these changes

@iamprazol iamprazol iamprazol approved these changes

@MILAN88888 MILAN88888 MILAN88888 approved these changes

Assignees

@dipuchaudhary dipuchaudhary

Labels
Approved bug Merged Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipuchaudhary @salimshrestha98 @iamprazol @MILAN88888