Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Accepting Numbers Below 0 Despite Minimum Limit of 0. #1145

Conversation

deepench
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Previously Accepted Values Below 0 Despite Setting Minimum Value to 0. This PR fixes this issue.

How to test the changes in this Pull Request:

  1. Create a form
  2. Sets the minimum value 0.
  3. Verify if the value is less than 0.

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

Fix - Accepting Numbers Below 0 Despite Minimum Limit of 0.

Copy link

@Sanjuacharya Sanjuacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepench deepench merged commit d612869 into develop Aug 23, 2023
1 check failed
@deepench deepench deleted the EVF-775-accepts-the-value-less-than-0-even-if-we-set-minimum-value-to-0 branch August 23, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants