Closes 2554: Prevent having a webp bigger than the original

[CrochetFeve0251]

Description

Fixes #2554

Display the message when we display a original format instead of the webp one.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality).

Is the solution different from the one proposed during the grooming?

No.

Checklists

Generic development checklist

• My code follows the style guidelines of this project, with adapted comments and without new warnings.
• I have added unit and integration tests that prove my fix is effective or that my feature works.
• The CI passes locally with my changes (including unit tests, integration tests, linter).
• Any dependent changes have been merged and published in downstream modules.
• If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
• I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

[remyperona]

I'm not understanding how the changes are preventing the WebP bigger than original?

Also, the referenced issue is not correct.

[remyperona]

We also have this PR related #706

[Mai-Saad]

@CrochetFeve0251 Thanks for the update. Please find exploratory test notes below
1- The served image at the FE has size > the optimized size (for this image WebP isnot generated, however it's served, shouldn't we serve png in this case? even if the option to display WebP image on the website is enabled @wp-media/productimagify ) test page https://imagify.rocketlabsqa.ovh/test-webp/


2- WebP generated is always no although it was generated (@wp-media/productimagify what shall be the text for convert when the image is converted to WebP? do we really need this field? /cc @MathieuLamiot )

on trunk

[MathieuLamiot]

@Mai-Saad, thanks for the detailed report.
About the 2nd point:

• If the WebP is generated (because it is smaller), then WebP Generated should be set to "Yes".
• If the WebP is not generated (because it is bigger, or for any other reasons actually), then WebP generated should be set to "No".
  I think it should be fixed as part of this issue @CrochetFeve0251

I do agree it seems a bit redundant with the message above saying WebP is not generated because it is bigger. It could be a small simplification, but let's see what @wp-media/productimagify thinks about this. We might not have all the cases in minds. In any case, that would be outside the scope of the issue..

[Mai-Saad]

@CrochetFeve0251 Thanks for the update. @MathieuLamiot Thanks for the feedback.
Currently:

• Specific image has no WebP generated while status is yes
  

• An image which isnot converted, is served with a bigger size (tested on chrome ubuntu) (note: this image wasnot compressed somehow)

[Mai-Saad]

@CrochetFeve0251 Thanks for the update. Working as the following now. If agreed by @wp-media/productimagify then we can merge. /cc @MathieuLamiot

1. Original image is non webp

• If generated WebP is < original image => no convert msg, WebP generated status is yes and served on FE if the serve option is enabled
• If generated WebP is > original image => convert msg Webp is less performant than original, WebP generated status is either No (if no webp file added to upload folder) or partial (if the webP file added to upload folder), image.extension is served on FE (as same as that in upload folder without extension nor dimensions and it is <= original size) if the serve webP option on/off

2- Original image is webP

• no convert msg, WebP generated status is No, The optimized image is served (approximately as same as that in upload folder )

3- Already on trunk, origional/ optimized size is not matching that in the upload folder https://wp-media.slack.com/archives/CU0F6EGQ1/p1699598198861799

4- Already on trunk, while display image in webp isnot checked, the used size at FE is that of webp but without adding webp extension https://wp-media.slack.com/archives/CU0F6EGQ1/p1699618969452739

[DahmaniAdame]

Looks good. The only change is on the wording to make it clearer about why the origin image will be served instead:

Change:

Webp is less performant than original

To:

WebP file is larger than the original image

[Mai-Saad]