Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 | Example code: remove use of E_STRICT #175

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 18, 2024

The E_STRICT constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0 (commit went in today).

The error level hasn't been in use since PHP 8.0 anyway and was only barely still used in PHP 7.x, so removing the exclusion from the error_reporting() setting in the example code shouldn't really make any difference in practice.

Ref:

The `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0 (commit went in today).

The error level hasn't been in use since PHP 8.0 anyway and was only barely still used in PHP 7.x, so removing the exclusion from the `error_reporting()` setting in the example code shouldn't really make any difference in practice.

Ref:
* https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant
@jrfnl jrfnl requested a review from a team as a code owner September 18, 2024 20:44
@swissspidy swissspidy added this to the 0.12.1 milestone Sep 24, 2024
@swissspidy swissspidy merged commit 75bb5ad into wp-cli:master Sep 24, 2024
15 checks passed
@jrfnl jrfnl deleted the feature/php-8.4-remove-estrict branch September 25, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants