PHP 8.1: fix "passing null to non-nullable" #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 8.1, passing `null` to not explicitly nullable scalar parameters for PHP native functions is deprecated.
In this case, the `Test_Table_Ascii::testSpacingInTable()` method passes a row with the following values: `array('A2', '', ' C2', null)`.
This then hits this deprecation in the `cli\table\Ascii::row()` method when calling the PHP native `str_replace()` function on line 141.
This can be seen when running the unit tests with `--display-deprecations`:
```
1) path/to/php-cli-tools/lib/cli/table/Ascii.php:141
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
Triggered by:
* Test_Table_Ascii::testSpacingInTable
path/to/php-cli-tools/tests/Test_Table_Ascii.php:120
```
There are two options here:
1. Fix the test to pass an empty string instead of `null` for the fourth cell.
2. Fix the method under test to handle potential `null` values more elegantly.
I'm not sure what the desired solution is in this case, so I've implemented solution 2 to maintain the existing behaviour, but can change this to solution 1 if so desired.
Refs:
* https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
swissspidy
approved these changes
Sep 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.1, passing
nullto not explicitly nullable scalar parameters for PHP native functions is deprecated.In this case, the
Test_Table_Ascii::testSpacingInTable()method passes a row with the following values:array('A2', '', ' C2', null). This then hits this deprecation in thecli\table\Ascii::row()method when calling the PHP nativestr_replace()function on line 141.This can be seen when running the unit tests with
--display-deprecations:There are two options here:
nullfor the fourth cell.nullvalues more elegantly.I'm not sure what the desired solution is in this case, so I've implemented solution 2 to maintain the existing behaviour, but can change this to solution 1 if so desired.
Refs: