-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve original image metadata, update only relevant size meta. #141
Preserve original image metadata, update only relevant size meta. #141
Conversation
Update testing framework.
Implement --image_size=<size> to regenerate a specific image size
Provide a more specific description
Fix Travis CI composer caching
Install Imagick for all versions of PHP.
Clarify this command as a bundled command
Change media noun to 'items' in most cases
WPCS fixes
This reverts commit 3f27d46.
wp_get_attachment_metadata() is better suited to fetch image metadata Co-authored-by: Lee Hanbury <lee.hanbury@gmail.com>
@mklepaczewski Thanks for the PR! To include this in the next release, we'll need to have functional tests as well that ensure this works as expected. Are you up for adding the missing test(s)? |
@schlessera I had hoped for someone to contribute these, as I have no experience with Behat. I'll do that, but I'm moving to a new apartment this weekend, I'm off on vacation next week, and I'll have to catch up with work the week after that, so please don't hold your breath. Keep it open, though. |
@mklepaczewski No worries, I'll look into adding the missing tests then. You better focus on your move. And enjoy your vacation! |
78bb587
to
e1f0370
Compare
@schlessera I've added the Behat tests, it's passing on some and failing on other environments. I couldn't figure out why can you please take a look? |
Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/9ce0653b91faa5151882b149fca38d02 in case this PR is auto-closed or broken in some way. |
de23a2c
to
f34a058
Compare
This patch addresses issue #130. When the
--image_size
option is used, it'll preserve original image metadata and update only relevant size information.I'm sorry, but no tests are provided as I'm not well versed with wp tests. Quite a few people reported the issue, so hopefully, someone will contribute their time to write the tests.