Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original image metadata, update only relevant size meta. #141

Closed

Conversation

mklepaczewski
Copy link

This patch addresses issue #130. When the --image_size option is used, it'll preserve original image metadata and update only relevant size information.

I'm sorry, but no tests are provided as I'm not well versed with wp tests. Quite a few people reported the issue, so hopefully, someone will contribute their time to write the tests.

schlessera and others added 30 commits April 6, 2017 16:33
Implement --image_size=<size> to regenerate a specific image size
Provide a more specific description
Fix Travis CI composer caching
Install Imagick for all versions of PHP.
Clarify this command as a bundled command
Change media noun to 'items' in most cases
This reverts commit 3f27d46.
@mklepaczewski mklepaczewski requested a review from a team as a code owner April 12, 2021 08:07
src/Media_Command.php Outdated Show resolved Hide resolved
wp_get_attachment_metadata()  is better suited to fetch image metadata

Co-authored-by: Lee Hanbury <lee.hanbury@gmail.com>
@schlessera
Copy link
Member

@mklepaczewski Thanks for the PR! To include this in the next release, we'll need to have functional tests as well that ensure this works as expected.

Are you up for adding the missing test(s)?

@mklepaczewski
Copy link
Author

@schlessera I had hoped for someone to contribute these, as I have no experience with Behat. I'll do that, but I'm moving to a new apartment this weekend, I'm off on vacation next week, and I'll have to catch up with work the week after that, so please don't hold your breath. Keep it open, though.

@schlessera
Copy link
Member

@mklepaczewski No worries, I'll look into adding the missing tests then. You better focus on your move. And enjoy your vacation!

@Sidsector9 Sidsector9 force-pushed the fix/issue-130-preserve-size-meta branch from 78bb587 to e1f0370 Compare May 11, 2022 21:18
@Sidsector9
Copy link
Member

@schlessera I've added the Behat tests, it's passing on some and failing on other environments. I couldn't figure out why can you please take a look?

@danielbachhuber
Copy link
Member

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/9ce0653b91faa5151882b149fca38d02 in case this PR is auto-closed or broken in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet