Skip to content

Commit

Permalink
Add in NIT fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Maxwell Dulin committed Jul 19, 2024
1 parent eac6ff4 commit fedf309
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion node/pkg/governor/governor.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ func NewChainGovernor(
env common.Environment,
coinGeckoApiKey string,
) *ChainGovernor {

return &ChainGovernor{
db: db,
logger: logger.With(zap.String("component", "cgov")),
Expand Down
2 changes: 1 addition & 1 deletion node/pkg/governor/governor_prices.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func createCoinGeckoQuery(ids string, coinGeckoApiKey string) string {
params.Add("vs_currencies", "usd")

// If modifying this code, ensure that the test 'TestCoinGeckoPriceChecks' passes when adding a pro API key to it.
// Since the code is requires an API key (which we don't want to publish to git), this
// Since the code requires an API key (which we don't want to publish to git), this
// part of the test is normally skipped but mods to sensitive places should still be checked
query := ""
if coinGeckoApiKey == "" {
Expand Down
2 changes: 1 addition & 1 deletion node/pkg/governor/governor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2817,7 +2817,7 @@ func TestCoinGeckoQueryFormat(t *testing.T) {
}

// Create and parse the query
queries := createCoinGeckoQueries(ids, 100, "") // Not API key
queries := createCoinGeckoQueries(ids, 100, "") // No API key
require.Equal(t, len(queries), 1)
query_url, err := url.Parse(queries[0])
require.Equal(t, err, nil)
Expand Down

0 comments on commit fedf309

Please sign in to comment.