Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana: Multi Transceiver Support #528

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

nvsriram
Copy link
Collaborator

@nvsriram nvsriram commented Oct 4, 2024

  • Refactor src/transceivers/* and src/messages.rs from Manager into NttTransceiver program
  • Add zero-copy deserialization helpers for ValidatedTransceiverMessage in Manager
  • Update release_outbound ix to CPI into Manager to mark outbox item as released.
  • Update Makefile to remove generics (if exists) from all programs
  • Update IDL

@nvsriram
Copy link
Collaborator Author

nvsriram commented Oct 4, 2024

SDK currently doesn't support multi-transceiver (it takes in a transceiver address at initialization and doesn't use it after that). Current TS changes are the minimum necessary to be able to test a custom transceiver.
However a proper refactor considering backwards compatibility and multi-transceiver support would be necessary.

One potential solution is to add a map/list for transceivers in the SolanaNtt class instead of the whTransceiverAddress. As a consequence, the getTransceiver function, SolanaNttWormholeTransceiver class, etc. would all need to be updated.

@kcsongor
Copy link
Contributor

kcsongor commented Oct 7, 2024

One potential solution is to add a map/list for transceivers in the SolanaNtt class instead of the whTransceiverAddress. As a consequence, the getTransceiver function, SolanaNttWormholeTransceiver class, etc. would all need to be updated.

this would be the most comprehensive solution, but might make sense to tackle it in a separate PR

@nvsriram
Copy link
Collaborator Author

nvsriram commented Oct 7, 2024

One potential solution is to add a map/list for transceivers in the SolanaNtt class instead of the whTransceiverAddress. As a consequence, the getTransceiver function, SolanaNttWormholeTransceiver class, etc. would all need to be updated.

this would be the most comprehensive solution, but might make sense to tackle it in a separate PR

That makes sense, I'll make a new PR that is based on this to implement the TS SDK refactor. At the end, we can merge both PRs together.

@nvsriram nvsriram marked this pull request as ready for review October 31, 2024 15:47
@nvsriram
Copy link
Collaborator Author

One potential solution is to add a map/list for transceivers in the SolanaNtt class instead of the whTransceiverAddress. As a consequence, the getTransceiver function, SolanaNttWormholeTransceiver class, etc. would all need to be updated.

this would be the most comprehensive solution, but might make sense to tackle it in a separate PR

That makes sense, I'll make a new PR that is based on this to implement the TS SDK refactor. At the end, we can merge both PRs together.

The TS SDK refactor is complete (with all CI jobs accounted for) and the PR is ready for review: #535 🎉

I think it makes chronological sense to review this PR first and then the TS SDK refactor PR as those changes are based off this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants