Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: add forge deployment script #215

Merged
merged 13 commits into from
Mar 13, 2024
Merged

evm: add forge deployment script #215

merged 13 commits into from
Mar 13, 2024

Conversation

gator-boi
Copy link
Contributor

No description provided.

@gator-boi gator-boi marked this pull request as draft February 27, 2024 16:54
@gator-boi gator-boi force-pushed the forge-deployment branch 10 times, most recently from a107522 to 9067bf2 Compare February 27, 2024 22:26
@gator-boi gator-boi marked this pull request as ready for review February 27, 2024 22:26
djb15
djb15 reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!

Will approve once the rate limit skipping PR has landed as the script will have to change slightly to accept the extra constructor

evm/script/ConfigureWormholeNtt.s.sol Outdated Show resolved Hide resolved
evm/script/ConfigureWormholeNtt.s.sol Outdated Show resolved Hide resolved
@gator-boi gator-boi requested a review from djb15 March 1, 2024 18:23
djb15
djb15 reviewed Mar 1, 2024
View reviewed changes
evm/script/DeployWormholeNtt.s.sol Outdated Show resolved Hide resolved
evm/script/ConfigureWormholeNtt.s.sol Outdated Show resolved Hide resolved
@gator-boi gator-boi force-pushed the forge-deployment branch 3 times, most recently from f64706c to b1f360c Compare March 13, 2024 14:56
solanoepalacio
solanoepalacio previously approved these changes Mar 13, 2024
View reviewed changes
@gator-boi gator-boi requested a review from djb15 March 13, 2024 15:03
RahulMaganti47
RahulMaganti47 reviewed Mar 13, 2024
View reviewed changes
evm/README.md Outdated Show resolved Hide resolved
RahulMaganti47
RahulMaganti47 reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@RahulMaganti47 RahulMaganti47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some readme additions

RahulMaganti47
RahulMaganti47 reviewed Mar 13, 2024
View reviewed changes
evm/script/DeployWormholeNtt.s.sol Outdated Show resolved Hide resolved
evm/script/DeployWormholeNtt.s.sol Outdated Show resolved Hide resolved
evm/script/DeployWormholeNtt.s.sol Show resolved Hide resolved
@gator-boi gator-boi merged commit f94fb1b into main Mar 13, 2024
4 checks passed
@gator-boi gator-boi deleted the forge-deployment branch March 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik-suri nik-suri nik-suri approved these changes

@RahulMaganti47 RahulMaganti47 RahulMaganti47 approved these changes

@djb15 djb15 Awaiting requested review from djb15

@solanoepalacio solanoepalacio Awaiting requested review from solanoepalacio

@kcsongor kcsongor Awaiting requested review from kcsongor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gator-boi @kcsongor @solanoepalacio @RahulMaganti47 @djb15 @nik-suri